Skip to content

Avoid redundant deduplication in reverse SCC upper bounds#159150

Open
NotPppp1116 wants to merge 1 commit into
rust-lang:mainfrom
NotPppp1116:optimize-reverse-scc-upper-bounds
Open

Avoid redundant deduplication in reverse SCC upper bounds#159150
NotPppp1116 wants to merge 1 commit into
rust-lang:mainfrom
NotPppp1116:optimize-reverse-scc-upper-bounds

Conversation

@NotPppp1116

Copy link
Copy Markdown

Remove redundant deduplication from ReverseSccGraph::upper_bounds.

depth_first_search already visits each reachable SCC at most once, and every universal region is stored in exactly one SCC range. Because of that, the FxIndexSet used to deduplicate returned regions cannot remove any duplicates.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 11, 2026
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 11, 2026
@rustbot

rustbot commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @ShoyuVanilla (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue
Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: borrowck, compiler
  • borrowck, compiler expanded to 75 candidates
  • Random selection from 18 candidates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants