Skip to content

Rollup of 2 pull requests#159588

Merged
rust-bors[bot] merged 7 commits into
rust-lang:mainfrom
jhpratt:rollup-52xc4vm
Jul 20, 2026
Merged

Rollup of 2 pull requests#159588
rust-bors[bot] merged 7 commits into
rust-lang:mainfrom
jhpratt:rollup-52xc4vm

Conversation

@jhpratt

@jhpratt jhpratt commented Jul 20, 2026

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost

Create a similar rollup

amirHdev and others added 7 commits July 11, 2026 15:05
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
…lcnr

Emit all borrowck errors at the end of borrowck

cc rust-lang/rust-project-goals#713

best reviewed commit by commit.

This changes some diagnostic ordering and tainting effects on diagnostics, but generally that should be an improvement as all diagnostics are sorted by their line numbers now

r? @lcnr
…onzero-matches, r=nnethercote

Add codegen test for signed nonzero matches

Closes rust-lang#84311
@rust-bors rust-bors Bot added the rollup A PR which is a rollup label Jul 20, 2026
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 20, 2026
@jhpratt

jhpratt commented Jul 20, 2026

Copy link
Copy Markdown
Member Author

@bors r+ rollup=never p=5

@rust-bors

rust-bors Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 2408dfe has been approved by jhpratt

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2026
@rust-bors

This comment has been minimized.

@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 20, 2026
@rust-bors

rust-bors Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: jhpratt
Duration: 3h 12m 5s
Pushing 14ead7d to main...

@rust-bors
rust-bors Bot merged commit 14ead7d into rust-lang:main Jul 20, 2026
14 checks passed
@rustbot rustbot added this to the 1.99.0 milestone Jul 20, 2026
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#158916 Emit all borrowck errors at the end of borrowck 28d3cd03df2f5c2c7380001c0166ed5f3a9d1ac9 (link)
#159129 Add codegen test for signed nonzero matches 717a8bda8c5ba24d8f62f20cdc0d7d89940b3ab1 (link)

previous master: 730a6b5dce

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 730a6b5 (parent) -> 14ead7d (this PR)

Test differences

Show 28 test diffs

Stage 1

  • [codegen] tests/codegen-llvm/issues/signed-nonzero-matches.rs: [missing] -> pass (J1)

Stage 2

  • [codegen] tests/codegen-llvm/issues/signed-nonzero-matches.rs: [missing] -> pass (J0)

Additionally, 26 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 14ead7d3d509f50efe9afb84673e65885dfd4d07 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-x86_64-msvc-alt: 1h 41m -> 2h 46m (+65.1%)
  2. x86_64-gnu-gcc-core-tests: 14m 21s -> 8m 32s (-40.5%)
  3. dist-arm-linux-gnueabi: 1h 4m -> 1h 28m (+38.6%)
  4. pr-check-1: 33m 6s -> 20m 24s (-38.4%)
  5. i686-msvc-1: 2h 18m -> 3h 2m (+31.6%)
  6. dist-aarch64-apple: 1h 29m -> 1h 55m (+29.1%)
  7. optional-x86_64-gnu-parallel-frontend: 2h 7m -> 1h 31m (-28.5%)
  8. dist-s390x-linux: 1h 12m -> 1h 31m (+26.3%)
  9. x86_64-msvc-ext2: 1h 38m -> 2h 2m (+24.1%)
  10. dist-powerpc64le-linux-musl: 1h 39m -> 1h 15m (-24.0%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (14ead7d): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary 3.9%, secondary 5.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
3.9% [3.9%, 3.9%] 1
Regressions ❌
(secondary)
5.7% [5.7%, 5.7%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 3.9% [3.9%, 3.9%] 1

Cycles

Results (primary 3.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
3.1% [2.3%, 3.9%] 2
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 3.1% [2.3%, 3.9%] 2

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 485.867s -> 485.673s (-0.04%)
Artifact size: 391.77 MiB -> 391.74 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants