Skip to content

reuse regular exported_non_generic_symbols logic in Miri#159740

Open
RalfJung wants to merge 2 commits into
rust-lang:mainfrom
RalfJung:miri-dedup-exported-symbols
Open

reuse regular exported_non_generic_symbols logic in Miri#159740
RalfJung wants to merge 2 commits into
rust-lang:mainfrom
RalfJung:miri-dedup-exported-symbols

Conversation

@RalfJung

@RalfJung RalfJung commented Jul 22, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

View all comments

This is some gnarly code we have duplicated in Miri, let's try to reuse the version from rustc.

r? @bjorn3

@rustbot

rustbot commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

miri is developed in its own repository. If the Miri part of this change can be broken out, consider making this change to rust-lang/miri instead. However, if Miri needs adjusting for rustc changes, just ignore this message.

cc @rust-lang/miri

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jul 22, 2026
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 22, 2026
@RalfJung
RalfJung force-pushed the miri-dedup-exported-symbols branch 3 times, most recently from e16cbd9 to 69ee67d Compare July 22, 2026 20:34
bjorn3
bjorn3 reviewed Jul 22, 2026
View reviewed changes
Comment thread src/tools/miri/src/bin/miri.rs
bjorn3
bjorn3 reviewed Jul 22, 2026
View reviewed changes
Comment thread src/tools/miri/src/helpers.rs Outdated
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@RalfJung
x test cargo-miri: run all subcrate tests as well
e3712ee 
also add a test for cross-crate static initializers
@RalfJung
RalfJung force-pushed the miri-dedup-exported-symbols branch from 69ee67d to 026f239 Compare July 23, 2026 07:07
@RalfJung

RalfJung commented Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

I pushed and the changes are not showing up... github is being github again...

It says changes will "appear soon" but in my experience that never happens.
EDIT: Looks like it did happen this time.

@RalfJung
RalfJung force-pushed the miri-dedup-exported-symbols branch from 026f239 to b5cd32c Compare July 23, 2026 07:44
RalfJung
RalfJung commented Jul 23, 2026
View reviewed changes
Comment thread compiler/rustc_passes/src/reachable.rs Outdated
RalfJung
RalfJung commented Jul 23, 2026
View reviewed changes
Comment thread src/tools/miri/src/shims/foreign_items.rs
@RalfJung
RalfJung force-pushed the miri-dedup-exported-symbols branch 2 times, most recently from 64ac2e0 to ab5dcb1 Compare July 23, 2026 16:31
bjorn3
bjorn3 reviewed Jul 23, 2026
View reviewed changes
Comment thread src/tools/miri/src/bin/miri.rs
@RalfJung
RalfJung force-pushed the miri-dedup-exported-symbols branch from ab5dcb1 to 410470a Compare July 23, 2026 16:34
@RalfJung
RalfJung force-pushed the miri-dedup-exported-symbols branch from 410470a to 7395449 Compare July 23, 2026 16:42
bjorn3
bjorn3 approved these changes Jul 23, 2026
View reviewed changes

@bjorn3 bjorn3 left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with CI green

View changes since this review

@RalfJung

RalfJung commented Jul 23, 2026

Copy link
Copy Markdown
Member Author

@bors r=bjorn3

@rust-bors

rust-bors Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 7395449 has been approved by bjorn3

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjorn3 bjorn3 bjorn3 approved these changes

Assignees

@bjorn3 bjorn3

Labels

A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RalfJung @rustbot @rust-log-analyzer @bjorn3