gcc: locate codegen-backends via host_tuple()#159753
Draft
xobs wants to merge 1 commit into
Draft
Conversation
`file_path` builds the `lib/rustlib/<host>/codegen-backends` path used to load the codegen backend. It passed `&sess.host.llvm_target`, but that is the host's LLVM target string, not its rustc target tuple. The two can differ (e.g. `arm64-apple-macosx` vs `aarch64-apple-darwin`), so the lookup can miss the directory that actually holds the backend. Use `rustc_session::config::host_tuple()` instead.
Collaborator
|
|
rustbot
added
S-waiting-on-review
Collaborator
|
r? @mejrs rustbot has assigned @mejrs. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
Author
|
Closing to send the PR to rustc_codegen_gcc instead |
rustbot
removed
the
S-waiting-on-review
rustbot
added
the
S-waiting-on-review
xobs
marked this pull request as draft
July 23, 2026 12:23
rustbot
added
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
file_pathbuilds thelib/rustlib/<host>/codegen-backendspath used to load the codegen backend. It passed&sess.host.llvm_target, but that is the host's LLVM target string, not its rustc target tuple. The two can differ (e.g.arm64-apple-macosxvsaarch64-apple-darwin), so the lookup can miss the directory that actually holds the backend. Userustc_session::config::host_tuple()instead.This fixes an issue when building custom toolchains. In particular, I'm using the gcc backend to build a custom SH4 compiler. Without this patch, this command fails to find the backend: