Skip to content

Avoid spurious rebuilds of JSON docs in bootstrap#159765

Open
Kobzol wants to merge 1 commit into
rust-lang:mainfrom
Kobzol:bootstrap-docs-json-rebuild
Open

Avoid spurious rebuilds of JSON docs in bootstrap#159765
Kobzol wants to merge 1 commit into
rust-lang:mainfrom
Kobzol:bootstrap-docs-json-rebuild

Conversation

@Kobzol

@Kobzol Kobzol commented Jul 23, 2026

Copy link
Copy Markdown
Member

Found this while working on #159671.

Before, repeated runs of e.g. x dist rust-docs-json always rebuilt the docs. It was caused by Cargo not knowing that the output should be JSON, so it was trying to find the HTML files.

Instead of passing the output format through RUSTDOCFLAGS, which Cargo doesn't inspect, we now pass it to Cargo directly, which fixes the issue.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jul 23, 2026
@rustbot

rustbot commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: bootstrap
  • bootstrap expanded to 6 candidates
  • Random selection from Mark-Simulacrum, clubby789, jieyouxu

@rust-log-analyzer

This comment was marked as outdated.

@Kobzol
Kobzol force-pushed the bootstrap-docs-json-rebuild branch from 2597b20 to 220fbca Compare July 23, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants