Avoid spurious rebuilds of JSON docs in bootstrap#159765
Open
Kobzol wants to merge 1 commit into
Open
Conversation
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment was marked as outdated.
This comment was marked as outdated.
Kobzol
force-pushed
the
bootstrap-docs-json-rebuild
branch
from
July 23, 2026 16:38
2597b20 to
220fbca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found this while working on #159671.
Before, repeated runs of e.g.
x dist rust-docs-jsonalways rebuilt the docs. It was caused by Cargo not knowing that the output should be JSON, so it was trying to find the HTML files.Instead of passing the output format through
RUSTDOCFLAGS, which Cargo doesn't inspect, we now pass it to Cargo directly, which fixes the issue.