Prefer T::SIZE over size_of::<T>() in core#159922
Draft
Lars-Schumann wants to merge 1 commit into
Draft
Conversation
rustbot
added
S-waiting-on-author
Contributor
|
@bors try @rust-timer queue |
Collaborator
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
rustbot
added
the
S-waiting-on-perf
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 25, 2026
…, r=<try> Prefer `T::SIZE` over `size_of::<T>()` in `core`
Contributor
Collaborator
|
Queued 6261a9a with parent da86f4d, future comparison URL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some context: #t-libs > Make more use of `SizedTypeProperties`
This only touches
coreand only changessize_of::<_>()->_::SIZEto keep the scope manageable.The motivation is mainly possible compile time wins and it's slightly more readable.
Since these were done mostly programmatically I will go over all changes again to make sure they are semantic no-ops and that no public docs were affected.