Skip to content

Rollup of 28 pull requests#159966

Open
JonathanBrouwer wants to merge 124 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-efqUEIj
Open

Rollup of 28 pull requests#159966
JonathanBrouwer wants to merge 124 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-efqUEIj

Conversation

@JonathanBrouwer

Copy link
Copy Markdown
Contributor

Successful merges:

r? @ghost

Create a similar rollup

moabo3li and others added 30 commits July 18, 2026 08:00
Use `local_to_op` and the operand storage shape to render initialized
immediate locals through Miri's Immediate display implementation.

Keep mplace-backed locals as `<indirect>` for now, preserve explicit
dead/uninit states, and expose interpreter errors in `LocalDesc`.value.

Add value-shape and metadata-sized local fixtures for the next indirect
rendering slices.
Resolve allocation-backed mplace locals and display their allocation
contents with dump_alloc.

Keep unsupported provenance as <indirect> and update the fixtures for the
temporary diagnostic allocation output.
This updates the rust-version file to c904ba3.
Replace the diagnostic dump_alloc output with a Priroda-owned byte renderer
for mplace-backed locals.

Compute the current value size with size_and_align_of_val, inspect only the
mplace byte range, and render uninitialized bytes with an explicit marker.
Render complete pointer provenance while dumping indirect local values.
Preserve initialized and uninitialized byte ranges, including padding and
partial pointer bytes, and report unsupported unsized values explicitly.

Add UI coverage for pointer positions, nonzero target offsets,
uninitialized regions, and partial provenance.
Add a `follow` command that renders allocation bytes starting at a given
allocation offset, reusing the provenance-aware allocation byte renderer used
for indirect locals.

Document the command and cover following a rendered pointer allocation in the
pointer-rendering UI test.
…dling

[Priroda] Render indirect local values
When using `RUSTFLAGS="-Ctarget-features=+avx512f"`, the Rust compiler
complains:

    error: unknown codegen option: `target-features`

The actual option uses the singular form.
…eature-typo

readme: fix misspelling of `-Ctarget-feature`
This updates the rust-version file to 1af98b7.
…nsic support"

This reverts commit 785e740bb5c1d9166717c93612f7b9f99fee1caf. The additional intrinsic support has meanwhile been implemented.
This commit is a change for all WASI targets to use a different
underlying implementation in the standard library for `thread_local!`.
Previously all wasm targets, without the `atomics` feature, were
funneled into the `no_threads` implementation and various fallbacks in
the `thread_local` module. The upcoming `wasm32-wasip3` target, however,
will actually have threads and will need different treatment.
Additionally the modules that `wasm32-wasip3` needs all already work on
all other WASI targets as well -- for example the `pthread_*` symbols
needed to manage destructors are exposed by `wasi-libc`.

The end result is that the `wasm32-wasip3` target will be "ready for
threads" as soon as `wasi-libc` has support. Other targets shouldn't
have any functional difference from before, too.
This updates the rust-version file to 390279b.
Add a CLI fixture covering a projected memory-backed field inside a larger
aggregate. This locks in that projected values render only their own MPlace
layout bytes instead of trailing bytes from the parent allocation.
Keep projected MIR Places long enough to evaluate them with
`eval_place_to_op`, then reuse the existing raw operand renderer for
immediate and memory-backed values.

This removes `<unsupported-projection>` from projected locals, including
fields, enum projections, references, and dereferences. Update the projected
debug-info UI expectations and verify the full Priroda suite.
[Priroda] Render projected debug-info values
@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs A-rustc-dev-guide Area: rustc-dev-guide A-testsuite Area: The testsuite used to check the correctness of rustc F-autodiff `#![feature(autodiff)]` PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jul 26, 2026
@JonathanBrouwer

Copy link
Copy Markdown
Contributor Author

@bors r+ rollup=never p=5

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple,x86_64-mingw-1,i686-msvc-*

@rust-bors

rust-bors Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

📌 Commit e6a1a8f has been approved by JonathanBrouwer

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

Reason for tree closure: spurious failures

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 26, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Jul 26, 2026
Rollup of 28 pull requests


try-job: dist-various-1
try-job: test-various
try-job: x86_64-gnu-aux
try-job: x86_64-gnu-llvm-21-3
try-job: x86_64-msvc-1
try-job: aarch64-apple
try-job: x86_64-mingw-1
try-job: i686-msvc-*
@JonathanBrouwer

Copy link
Copy Markdown
Contributor Author

@bors p=100

@rust-bors

rust-bors Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

⌛ Testing commit e6a1a8f with merge 6dc7429...

Workflow: https://github.com/rust-lang/rust/actions/runs/30210726766

rust-bors Bot pushed a commit that referenced this pull request Jul 26, 2026
…uwer

Rollup of 28 pull requests

Successful merges:

 - #159638 (bootstrap: Split the `Step` trait into multiple traits)
 - #159774 (rustc_trait_selection: fix trait solver hang caused by degenerate obligations)
 - #159837 (line-tables-only test: check that the line number matches the function name)
 - #159946 (Update Enzyme submodule to imporve llvm-cov)
 - #159962 (miri subtree update)
 - #156570 (tests: extend remap-path-prefix-std to all stdlib rlibs)
 - #159617 (Fix up `#[linkage]` target checking)
 - #159633 (Improve workings of attribute suggestions)
 - #159733 (std: Switch implementations of `thread_local!` for WASI)
 - #159783 (Check unsafe impls on safe EIIs)
 - #159810 (Add tuple never coercion collection regression test)
 - #159826 (Remove redundant `#[rustc_paren_sugar]` feature gate)
 - #159846 (Implement `str::copy_from_str`)
 - #159849 (rustc_parse: Stop returning `Option` from statement parsing)
 - #159853 (Updated expect messages for `CString` struct and method documentation)
 - #159875 (More cleanup in `rustc_attr_parsing`)
 - #159882 (Update expect messages in library/alloc/boxed.rs and library/alloc/string.rs to follow the style guide)
 - #159891 (Split multiline derives into std/rustc macros)
 - #159893 (Fix `find_attr` hygiene and `rustc_hir` cleanups)
 - #159895 (rustc-dev-guide subtree update)
 - #159902 (Clarify that the expected runtime symbols signature is for the current target only)
 - #159914 (Fix error in diagnostic on_unmatched_args)
 - #159917 (spare capacity mut constification)
 - #159918 (rename abort_unwind → abort_on_unwind)
 - #159927 (Remove sve2 from the ImpliedFeatures of AArch64 v9a.)
 - #159936 (Minor `rustc_ast::ast` doc cleanups)
 - #159945 (Update expect messages in library/core/src/ptr/non_null.rs)
 - #159950 (Add CFI tests for return types and never type)
@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job x86_64-mingw-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
---- [run-make] tests\run-make-cargo\amdgpu-lto stdout ----

error: rmake recipe failed to complete
status: exit code: 1
command: "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\run-make-cargo\\amdgpu-lto\\rmake.exe"
stdout: none
--- stderr -------------------------------
command failed at line 27
"D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\stage2-tools-bin\\cargo.exe" "build" "--release" "--lib" "--manifest-path" "Cargo.toml" "-Zbuild-std=core" "--target" "amdgcn-amd-amdhsa"
output status: `exit code: 101`
---
    Blocking waiting for file lock on package cache
    Blocking waiting for file lock on package cache
   Compiling compiler_builtins v0.1.160 (D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage2\lib\rustlib\src\rust\library\compiler-builtins\compiler-builtins)
   Compiling core v0.0.0 (D:\a\rust\rust\build\x86_64-pc-windows-gnu\stage2\lib\rustlib\src\rust\library\core)
   Compiling amdgpu_lto v0.1.0 (D:\a\rust\rust\build\x86_64-pc-windows-gnu\test\run-make-cargo\amdgpu-lto\rmake_out)
error: linking with `rust-lld` failed: exit code: 0xc0000374
  |
  = note: "rust-lld" "-flavor" "gnu" "--version-script=D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\run-make-cargo\\amdgpu-lto\\rmake_out\\target\\amdgcn-amd-amdhsa\\release\\deps\\rustcuN53RH\\list" "--no-undefined-version" "<1 object files omitted>" "--as-needed" "-L" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\run-make-cargo\\amdgpu-lto\\rmake_out\\target\\amdgcn-amd-amdhsa\\release\\deps\\rustcuN53RH\\raw-dylibs" "-Bdynamic" "--eh-frame-hdr" "-z" "noexecstack" "-o" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\run-make-cargo\\amdgpu-lto\\rmake_out\\target\\amdgcn-amd-amdhsa\\release\\deps\\amdgpu_lto.elf" "--gc-sections" "-shared" "-O1" "--strip-debug"
  = note: some arguments are omitted. use `--verbose` to show all linker arguments
  = note: 

error: could not compile `amdgpu_lto` (lib) due to 1 previous error
------------------------------------------

---- [run-make] tests\run-make-cargo\amdgpu-lto stdout end ----

failures:
---
Currently active steps:
test::RunMakeCargo { test_compiler: Compiler { stage: 2, host: x86_64-pc-windows-gnu, forced_compiler: false }, target: x86_64-pc-windows-gnu } at src\bootstrap\src\core\build_steps\test.rs:1965
test::Compiletest { test_compiler: Compiler { stage: 2, host: x86_64-pc-windows-gnu, forced_compiler: false }, target: x86_64-pc-windows-gnu, mode: run-make, suite: "run-make-cargo", path: "tests/run-make-cargo", compare_mode: None } at src\bootstrap\src\core\build_steps\test.rs:1965
Build completed unsuccessfully in 3:01:43
make: *** [Makefile:126: ci-mingw-x] Error 1
  local time: Sun Jul 26 16:58:51 CUT 2026
  network time: Sun, 26 Jul 2026 16:58:51 GMT
##[error]Process completed with exit code 2.
##[group]Run echo "disk usage:"
echo "disk usage:"

@rust-bors rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 26, 2026
@rust-bors

rust-bors Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

💔 Test for a23f299 failed: CI. Failed job:

@JonathanBrouwer

Copy link
Copy Markdown
Contributor Author

@bors r-

@rust-bors rust-bors Bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 26, 2026
@rust-bors

rust-bors Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

Auto build was cancelled due to unapproval. Cancelled workflows:

View changes since this unapproval

@JonathanBrouwer

Copy link
Copy Markdown
Contributor Author

No clue which PR caused this, started some try jobs while I'm allowing rollup=never prs to run

@JonathanBrouwer

Copy link
Copy Markdown
Contributor Author

Just making sure this reproduces
@bors try jobs=x86_64-mingw-1

@rust-bors

rust-bors Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

⌛ Trying commit e6a1a8f with merge 37fa134

To cancel the try build, run the command @bors try cancel.

Workflow: https://github.com/rust-lang/rust/actions/runs/30214548873

rust-bors Bot pushed a commit that referenced this pull request Jul 26, 2026
Rollup of 28 pull requests


try-job: x86_64-mingw-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-run-make Area: port run-make Makefiles to rmake.rs A-rustc-dev-guide Area: rustc-dev-guide A-testsuite Area: The testsuite used to check the correctness of rustc F-autodiff `#![feature(autodiff)]` PG-exploit-mitigations Project group: Exploit mitigations rollup A PR which is a rollup S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.