Fix typing mode handling in transmute checks and rustc_dump_layout - #160125
Open
bit-aloo wants to merge 3 commits into
Open
Fix typing mode handling in transmute checks and rustc_dump_layout#160125bit-aloo wants to merge 3 commits into
bit-aloo wants to merge 3 commits into
Conversation
… around rigid alias
Collaborator
|
|
rust-cloud-vms
Bot
force-pushed
the
2026-07-29-next-solver-typing-bugs
branch
from
July 29, 2026 08:56
d67cb2c to
6c348ec
Compare
adwinwhite
reviewed
Jul 29, 2026
Contributor
|
@rustbot author |
Types obtained from typeck_results may contain aliases marked as rigid for their original typing environment. Make these aliases non-rigid before normalizing transmute types in TypingMode::Codegen. Also use TypingMode::Codegen in rustc_dump_layout, since opaque types may normalize to coroutines whose layouts cannot be computed in PostAnalysis mode. Add regression coverage for both cases.
rust-cloud-vms
Bot
force-pushed
the
2026-07-29-next-solver-typing-bugs
branch
from
July 30, 2026 09:26
6c348ec to
9d94e8a
Compare
Member
Author
|
@adwinwhite I might need delegate to push to bors. |
adwinwhite
reviewed
Jul 30, 2026
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
|
One last nit :> |
Contributor
|
✌️ @bit-aloo, you can now approve this pull request! If @adwinwhite told you to " |
…old solver behavior depicted.
Member
Author
|
@bors r=adwinwhite |
Contributor
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jul 30, 2026
…ping-bugs, r=adwinwhite Fix typing mode handling in transmute checks and rustc_dump_layout closes: rust-lang/trait-system-refactor-initiative#283 r? @adwinwhite cc: @lcnr
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 30, 2026
Rollup of 14 pull requests Successful merges: - #159817 (Rename splat to avoid stable name collisions) - #160204 (Sync from portable simd 2026 07 30) - #150885 (Revive L4Re target) - #158057 (Don't escape U+FF9E and U+FF9F in `escape_debug_ext`) - #160125 (Fix typing mode handling in transmute checks and rustc_dump_layout) - #160152 (Create on-demand CI job for testing EC2 instances) - #159214 (std: improve the documentation of the random feature) - #159818 (Resolve vars before calling `unnormalized_obligations`) - #160040 (Split function parsing out of `item.rs` to a new module.) - #160044 (Add regression tests for fixed dead-code issues) - #160144 (renovate: group lockfiles PRs) - #160149 (Fix Windows on Arm PAC default) - #160175 (Try to recover less from incorrectly parsed const arg) - #160181 (Mark `Tuple` and `FnPtr` traits `#[fundamental]`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: rust-lang/trait-system-refactor-initiative#283
r? @adwinwhite
cc: @lcnr