Add documentation for the target_feature attribute - #160218
Open
valentynkit wants to merge 2 commits into
Open
Conversation
Document the built-in `target_feature` attribute in the standard library using the `#[doc(attribute = "...")]` mechanism, following the existing `inline` and `cold` attribute documentation.
The Reference already lists where the attribute may appear, and these entries are meant to stay guide-level rather than exhaustive.
rustbot
added
the
S-waiting-on-review
rustbot
added
the
T-libs
Member
|
I don't know too much about this attribute so I prefer letting someone else review it. r? @RalfJung |
Collaborator
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents the
target_featureattribute, the next one from my claim on the tracking issue.The example is wrapped in a hidden
#[cfg(target_arch = "x86_64")]block, since feature names are architecture specific and the example has to compile everywhere the doctests run.Part of #157604
r? @GuillaumeGomez
Tested with
./x test library/core --doc --test-args attribute_docsand the same forlibrary/std.