Rollup of 3 pull requests by jhpratt · Pull Request #160414 · rust-lang/rust

jhpratt · 2026-08-03T04:44:34Z

Successful merges:

Don't use exported generics from conditional dependencies (panic runtimes and profiler-builtins) #160306 (Don't use exported generics from conditional dependencies (panic runtimes and profiler-builtins))
Rerun the goal with doubled recursion limit even if the goal has ty vars #160254 (Rerun the goal with doubled recursion limit even if the goal has ty vars)
Improve the test for patterns in fn pointers #160380 (Improve the test for patterns in fn pointers)

…, r=bjorn3 Don't use exported generics from conditional dependencies (panic runtimes and profiler-builtins) This is a fix for rust-lang#159682. This seems like a generalized footgun for writing FFI plugins? But at least right now, a very specific change to the crates we often swap around seems prudent.

Rerun the goal with doubled recursion limit even if the goal has ty vars Fix the `bevy_render` regression and more in the next solver crater run. The problem is that we don't rerun the root goal with doubled recursion limit if it contains ty vars. But we actually need the evaluation response to resolve the ty vars. So the type inference fails.

…t, r=khyperia Improve the test for patterns in fn pointers Follow up of rust-lang#160282 The goal is to cover more cases of the behaviour of patterns in fn pointers.

jhpratt · 2026-08-03T04:44:49Z

@bors r+ rollup=never p=5

rust-bors · 2026-08-03T04:44:51Z

📌 Commit 9e756da has been approved by jhpratt

It is now in the queue for this repository.

rust-log-analyzer · 2026-08-03T04:50:15Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

jhpratt · 2026-08-03T04:51:37Z

spurious; letting run continue

Rollup of 3 pull requests Successful merges: - #160306 (Don't use exported generics from conditional dependencies (panic runtimes and profiler-builtins)) - #160254 (Rerun the goal with doubled recursion limit even if the goal has ty vars) - #160380 (Improve the test for patterns in fn pointers)

rust-bors · 2026-08-03T05:42:07Z

💔 Test for a182dd9 failed: CI. Failed job:

auto - dist-various-1 (web logs, enhanced plaintext logs)

jhpratt · 2026-08-03T05:43:41Z

@bors treeclosed=5 spurious failures

@bors retry

rust-bors · 2026-08-03T05:43:44Z

Tree closed for PRs with priority less than 5.

rust-log-analyzer · 2026-08-03T05:47:38Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

JonathanBrouwer · 2026-08-03T08:11:37Z

@bors treeopen

rust-bors · 2026-08-03T08:11:41Z

Tree is now open for merging.

rust-bors · 2026-08-03T08:55:54Z

☀️ Test successful - CI
Approved by: jhpratt
Duration: 3h 11m 26s
Pushing 7c329d6 to main...

rust-timer · 2026-08-03T08:56:50Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#160306	Don't use exported generics from conditional dependencies (…	`afa89e1bca83b15cd32ab43c762db9dd2f343e0c` (link)
#160254	Rerun the goal with doubled recursion limit even if the goa…	`0a20f67f58f79b5719070d66e2e8679281002182` (link)
#160380	Improve the test for patterns in fn pointers	`aad2d2b627e669673a3643b558b547ab8e6952ae` (link)

previous master: 65dd30fb9e

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2026-08-03T08:59:17Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 65dd30f (parent) -> 7c329d6 (this PR)

Test differences

Show 6 test diffs

Stage 1

[ui] tests/ui/traits/next-solver/overflow-discards-constraints.rs: [missing] -> pass (J0)
[ui (polonius)] tests/ui/traits/next-solver/overflow-discards-constraints.rs: [missing] -> pass (J2)

Stage 2

[ui] tests/ui/traits/next-solver/overflow-discards-constraints.rs: [missing] -> pass (J1)

Additionally, 3 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 7c329d6c76e11ca40c5673818ab0439c1be8962c --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-gnu: 1h 46m -> 2h 38m (+49.0%)
armhf-gnu: 1h 3m -> 1h 33m (+47.9%)
dist-powerpc-linux: 1h 7m -> 1h 34m (+40.0%)
x86_64-gnu-gcc: 48m 45s -> 1h 7m (+38.1%)
dist-x86_64-solaris: 1h 12m -> 1h 37m (+34.6%)
x86_64-gnu-next-trait-solver-polonius: 1h 1m -> 41m 23s (-32.3%)
dist-riscv64-linux-gnu: 1h 10m -> 1h 31m (+30.7%)
dist-i686-linux: 1h 25m -> 1h 51m (+30.5%)
x86_64-gnu-aux: 2h 2m -> 2h 35m (+26.9%)
dist-x86_64-linux-alt: 1h 53m -> 2h 23m (+26.5%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-08-03T10:29:57Z

Finished benchmarking commit (7c329d6): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary 3.2%, secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.2%	[0.6%, 4.9%]	3
Regressions ❌ (secondary)	5.0%	[5.0%, 5.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.7%	[-1.1%, -0.4%]	7
All ❌✅ (primary)	3.2%	[0.6%, 4.9%]	3

Cycles

Results (primary 0.3%, secondary -0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.3%	[0.4%, 2.6%]	7
Regressions ❌ (secondary)	1.9%	[0.7%, 4.3%]	5
Improvements ✅ (primary)	-0.7%	[-1.2%, -0.4%]	7
Improvements ✅ (secondary)	-1.6%	[-4.3%, -0.4%]	8
All ❌✅ (primary)	0.3%	[-1.2%, 2.6%]	14

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 491.898s -> 491.018s (-0.18%)
Artifact size: 391.08 MiB -> 390.29 MiB (-0.20%)

saethlin and others added 7 commits August 1, 2026 14:34

Don't use exported generics from conditional dependencies

601ee8e

Improve the layout of the test

32ba9ca

Test syntax of patterns in fn ptrs

c25abc5

rerun even if the goal has ty vars

1489e47

Rollup merge of rust-lang#160380 - JonathanBrouwer:improve-fn-ptr-tes…

9e756da

…t, r=khyperia Improve the test for patterns in fn pointers Follow up of rust-lang#160282 The goal is to cover more cases of the behaviour of patterns in fn pointers.

rust-bors Bot added the rollup A PR which is a rollup label Aug 3, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Aug 3, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 3, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 3, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 3, 2026

rust-bors Bot mentioned this pull request Aug 3, 2026

Don't use exported generics from conditional dependencies (panic runtimes and profiler-builtins) #160306

Merged

This comment has been minimized.

Sign in to view

rust-bors Bot mentioned this pull request Aug 3, 2026

fix borrowck ICE for consts with fn pointer type #160314

Open

This was referenced Aug 3, 2026

DepKind cleanups #160406

Open

Add PR body notes for Cargo lock file maintenance #160384

Open

Fix ICE for direct inline const generic defaults #159303

Open

rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 3, 2026

rust-bors Bot merged commit 7c329d6 into rust-lang:main Aug 3, 2026
3 of 14 checks passed

rustbot added this to the 1.99.0 milestone Aug 3, 2026

Uh oh!

Uh oh!

Conversation

jhpratt commented Aug 3, 2026

Uh oh!

jhpratt commented Aug 3, 2026

Uh oh!

rust-bors Bot commented Aug 3, 2026

Uh oh!

rust-log-analyzer commented Aug 3, 2026

Uh oh!

jhpratt commented Aug 3, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Aug 3, 2026

Uh oh!

jhpratt commented Aug 3, 2026

Uh oh!

rust-bors Bot commented Aug 3, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Aug 3, 2026

Uh oh!

JonathanBrouwer commented Aug 3, 2026

Uh oh!

rust-bors Bot commented Aug 3, 2026

Uh oh!

rust-bors Bot commented Aug 3, 2026

Uh oh!

Uh oh!

rust-timer commented Aug 3, 2026

Uh oh!

github-actions Bot commented Aug 3, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Aug 3, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants