Merge compiletest directives to do with llvm versions - #160637
Open
WaffleLapkin wants to merge 5 commits into
Open
Merge compiletest directives to do with llvm versions#160637WaffleLapkin wants to merge 5 commits into
WaffleLapkin wants to merge 5 commits into
Conversation
Collaborator
|
Some changes occurred in src/tools/compiletest cc @jieyouxu Some changes occurred in coverage tests. cc @Zalathar
|
rustbot
added
A-compiletest
Collaborator
|
|
rustbot
added
F-explicit_tail_calls
WaffleLapkin
commented
Aug 6, 2026
| assert_eq!(extract_llvm_version("9.0.1-rust-1.43.0-dev"), Version::new(9, 0, 1)); | ||
| assert_eq!(extract_llvm_version("9.3.1-rust-1.43.0-dev"), Version::new(9, 3, 1)); | ||
| assert_eq!(extract_llvm_version("10.0.0-rust"), Version::new(10, 0, 0)); | ||
| // assert_eq!(extract_llvm_version("4.5.6git"), Version::new(4, 5, 6)); |
Member
Author
There was a problem hiding this comment.
Is this an actual version string that llvm outputs? In that case I'll have to (partially?) revert the change to extract_llvm_version...
This comment has been minimized.
This comment has been minimized.
Instead of having separate directives for major versions and whatnot, just use the semver version requirement.
…vm-version` If we don't want them to combine we should explicitly disallow them...
WaffleLapkin
force-pushed
the
llvm-version-less-than-three
branch
from
August 6, 2026 13:27
cfd0ca7 to
968a931
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got confused by
min-llvm-versionandmax-llvm-major-versionbeing different not only inmin/max(-major).... So I decided to refactor everything to just use semver version requirements (
//@ llvm-version: <=22, etc). IMO this is much nicer.r? @jieyouxu