mir: validate Move call arguments are locals or box derefs - #160651
Draft
rabindra789 wants to merge 1 commit into
Draft
mir: validate Move call arguments are locals or box derefs#160651rabindra789 wants to merge 1 commit into
Move call arguments are locals or box derefs#160651rabindra789 wants to merge 1 commit into
Conversation
Collaborator
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
Collaborator
|
r? @mati865 rustbot has assigned @mati865. Use Why was this reviewer chosen?The reviewer was selected based on:
|
rabindra789
marked this pull request as draft
August 6, 2026 18:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #103362.
When a
CallorTailCallargument isOperand::Move(place), the callee receives the place by reference. Such moves are only valid for plain locals or the contents of a box (a singleDerefof a box-typed local).Add a verifier check under
-Zvalidate-mir, using the same phase gate as the existingOperand::Copyvalidation. This avoids affecting the unconditional validation after the final optimization phase.The regression test uses custom MIR to verify that invalid move arguments are rejected. Rustc-generated MIR is unaffected because move arguments are materialized into temporaries before calls.