Skip to content

[WIP] - moving trivial field reads attr to macros - #160666

Draft
josetorrs wants to merge 2 commits into
rust-lang:mainfrom
josetorrs:move-trivial-reads-to-macros
Draft

[WIP] - moving trivial field reads attr to macros#160666
josetorrs wants to merge 2 commits into
rust-lang:mainfrom
josetorrs:move-trivial-reads-to-macros

Conversation

@josetorrs

@josetorrs josetorrs commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

part of #160621. also discussion in #t-lang > diagnostics attribute to ignore code for unused_code lints

  • I did not use an LLM to create a change in this PR.
  • I used an LLM to create a change in this PR, and I have explained below how it was used.

r? @mejrs

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 7, 2026
josetorrs
josetorrs commented Aug 7, 2026
View reviewed changes
Comment thread compiler/rustc_passes/src/dead.rs
Comment on lines +441 to +442
&& let Some(macro_def_id) = impl_item.span.ctxt().outer_expn_data().macro_def_id
&& find_attr!(self.tcx, macro_def_id, RustcTrivialFieldReads)

@josetorrs josetorrs Aug 7, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH not really sure about this but my computer has been really slow so wanted to see what CI would do

View changes since the review

@rust-log-analyzer

rust-log-analyzer commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

The job aarch64-gnu-llvm-21-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
---- [ui] tests/ui/traits/const-traits/minicore-const-fn-early-bound.rs stdout ----

error: auxiliary build of /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs failed to compile: 
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2" "--target=aarch64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--out-dir" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/traits/const-traits/minicore-const-fn-early-bound/auxiliary" "-A" "internal_features" "-A" "incomplete_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/aarch64-unknown-linux-gnu/native/rust-test-helpers" "-Znext-solver" "-Cpanic=abort" "-L" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/traits/const-traits/minicore-const-fn-early-bound/auxiliary"
stdout: none
--- stderr -------------------------------
error: the `rustc_trivial_field_reads` attribute cannot be used on traits
##[error]  --> /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs:448:3
   |
---

warning: unused variable: `x`
##[warning]  --> /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs:52:9
   |
LL |     let x = 42_i32 + 43_i32;
   |         ^ help: if this is intentional, prefix it with an underscore: `_x`

warning: unused variable: `x`
##[warning]  --> /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs:56:9
   |
LL |     let x = 42_i32 + 43_i32;
   |         ^ help: if this is intentional, prefix it with an underscore: `_x`

warning: unused variable: `bytes`
##[warning]  --> /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs:149:28
   |
LL |     const fn from_ne_bytes(bytes: [u8; size_of::<Self>()]) -> Self {
   |                            ^^^^^ help: if this is intentional, prefix it with an underscore: `_bytes`

warning: unused variable: `other`
##[warning]  --> /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs:319:18
   |
LL |     fn eq(&self, other: &str) -> bool {
   |                  ^^^^^ help: if this is intentional, prefix it with an underscore: `_other`

warning: unused variable: `value`
##[warning]  --> /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs:417:18
   |
LL |     const fn new(value: T) -> RefCell<T> {
---
---- [ui] tests/ui/traits/const-traits/minicore-deref-fail.rs stdout ----

error: auxiliary build of /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs failed to compile: 
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2" "--target=aarch64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--out-dir" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/traits/const-traits/minicore-deref-fail/auxiliary" "-A" "internal_features" "-A" "incomplete_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/aarch64-unknown-linux-gnu/native/rust-test-helpers" "-Znext-solver" "-Cpanic=abort" "-L" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/traits/const-traits/minicore-deref-fail/auxiliary"
stdout: none
--- stderr -------------------------------
error: the `rustc_trivial_field_reads` attribute cannot be used on traits
##[error]  --> /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs:448:3
   |
---

warning: unused variable: `x`
##[warning]  --> /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs:52:9
   |
LL |     let x = 42_i32 + 43_i32;
   |         ^ help: if this is intentional, prefix it with an underscore: `_x`

warning: unused variable: `x`
##[warning]  --> /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs:56:9
   |
LL |     let x = 42_i32 + 43_i32;
   |         ^ help: if this is intentional, prefix it with an underscore: `_x`

warning: unused variable: `bytes`
##[warning]  --> /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs:149:28
   |
LL |     const fn from_ne_bytes(bytes: [u8; size_of::<Self>()]) -> Self {
   |                            ^^^^^ help: if this is intentional, prefix it with an underscore: `_bytes`

warning: unused variable: `other`
##[warning]  --> /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs:319:18
   |
LL |     fn eq(&self, other: &str) -> bool {
   |                  ^^^^^ help: if this is intentional, prefix it with an underscore: `_other`

warning: unused variable: `value`
##[warning]  --> /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs:417:18
   |
LL |     const fn new(value: T) -> RefCell<T> {
---
---- [ui] tests/ui/traits/const-traits/minicore-drop-fail.rs stdout ----

error: auxiliary build of /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs failed to compile: 
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2" "--target=aarch64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--out-dir" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/traits/const-traits/minicore-drop-fail/auxiliary" "-A" "internal_features" "-A" "incomplete_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/aarch64-unknown-linux-gnu/native/rust-test-helpers" "-Znext-solver" "-Cpanic=abort" "-L" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/traits/const-traits/minicore-drop-fail/auxiliary"
stdout: none
--- stderr -------------------------------
error: the `rustc_trivial_field_reads` attribute cannot be used on traits
##[error]  --> /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs:448:3
   |
---

warning: unused variable: `x`
##[warning]  --> /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs:52:9
   |
LL |     let x = 42_i32 + 43_i32;
   |         ^ help: if this is intentional, prefix it with an underscore: `_x`

warning: unused variable: `x`
##[warning]  --> /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs:56:9
   |
LL |     let x = 42_i32 + 43_i32;
   |         ^ help: if this is intentional, prefix it with an underscore: `_x`

warning: unused variable: `bytes`
##[warning]  --> /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs:149:28
   |
LL |     const fn from_ne_bytes(bytes: [u8; size_of::<Self>()]) -> Self {
   |                            ^^^^^ help: if this is intentional, prefix it with an underscore: `_bytes`

warning: unused variable: `other`
##[warning]  --> /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs:319:18
   |
LL |     fn eq(&self, other: &str) -> bool {
   |                  ^^^^^ help: if this is intentional, prefix it with an underscore: `_other`

warning: unused variable: `value`
##[warning]  --> /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs:417:18
   |
LL |     const fn new(value: T) -> RefCell<T> {
---
---- [ui] tests/ui/traits/const-traits/minicore-drop-without-feature-gate.rs#no stdout ----

error in revision `no`: auxiliary build of /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs failed to compile: 
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2" "--target=aarch64-unknown-linux-gnu" "--cfg" "no" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--out-dir" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/traits/const-traits/minicore-drop-without-feature-gate.no/auxiliary" "-A" "internal_features" "-A" "incomplete_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/aarch64-unknown-linux-gnu/native/rust-test-helpers" "-Znext-solver" "-Cpanic=abort" "-L" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/traits/const-traits/minicore-drop-without-feature-gate.no/auxiliary"
stdout: none
--- stderr -------------------------------
error: the `rustc_trivial_field_reads` attribute cannot be used on traits
##[error]  --> /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs:448:3
   |
---

warning: unused variable: `x`
##[warning]  --> /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs:52:9
   |
LL |     let x = 42_i32 + 43_i32;
   |         ^ help: if this is intentional, prefix it with an underscore: `_x`

warning: unused variable: `x`
##[warning]  --> /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs:56:9
   |
LL |     let x = 42_i32 + 43_i32;
   |         ^ help: if this is intentional, prefix it with an underscore: `_x`

warning: unused variable: `bytes`
##[warning]  --> /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs:149:28
   |
LL |     const fn from_ne_bytes(bytes: [u8; size_of::<Self>()]) -> Self {
   |                            ^^^^^ help: if this is intentional, prefix it with an underscore: `_bytes`

warning: unused variable: `other`
##[warning]  --> /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs:319:18
   |
LL |     fn eq(&self, other: &str) -> bool {
   |                  ^^^^^ help: if this is intentional, prefix it with an underscore: `_other`

warning: unused variable: `value`
##[warning]  --> /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs:417:18
   |
LL |     const fn new(value: T) -> RefCell<T> {
---
---- [ui] tests/ui/traits/const-traits/minicore-fn-fail.rs stdout ----

error: auxiliary build of /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs failed to compile: 
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2" "--target=aarch64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--out-dir" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/traits/const-traits/minicore-fn-fail/auxiliary" "-A" "internal_features" "-A" "incomplete_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/aarch64-unknown-linux-gnu/native/rust-test-helpers" "-Znext-solver" "-Cpanic=abort" "-L" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/traits/const-traits/minicore-fn-fail/auxiliary"
stdout: none
--- stderr -------------------------------
error: the `rustc_trivial_field_reads` attribute cannot be used on traits
##[error]  --> /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs:448:3
   |
---

warning: unused variable: `x`
##[warning]  --> /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs:52:9
   |
LL |     let x = 42_i32 + 43_i32;
   |         ^ help: if this is intentional, prefix it with an underscore: `_x`

warning: unused variable: `x`
##[warning]  --> /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs:56:9
   |
LL |     let x = 42_i32 + 43_i32;
   |         ^ help: if this is intentional, prefix it with an underscore: `_x`

warning: unused variable: `bytes`
##[warning]  --> /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs:149:28
   |
LL |     const fn from_ne_bytes(bytes: [u8; size_of::<Self>()]) -> Self {
   |                            ^^^^^ help: if this is intentional, prefix it with an underscore: `_bytes`

warning: unused variable: `other`
##[warning]  --> /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs:319:18
   |
LL |     fn eq(&self, other: &str) -> bool {
   |                  ^^^^^ help: if this is intentional, prefix it with an underscore: `_other`

warning: unused variable: `value`
##[warning]  --> /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs:417:18
   |
LL |     const fn new(value: T) -> RefCell<T> {
---

---- [ui] tests/ui/traits/const-traits/minicore-fn-fail.rs stdout end ----
---- [ui] tests/ui/traits/const-traits/minicore-drop-without-feature-gate.rs#yes stdout ----

error in revision `yes`: auxiliary build of /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs failed to compile: 
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2" "--target=aarch64-unknown-linux-gnu" "--cfg" "yes" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--out-dir" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/traits/const-traits/minicore-drop-without-feature-gate.yes/auxiliary" "-A" "internal_features" "-A" "incomplete_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/aarch64-unknown-linux-gnu/native/rust-test-helpers" "-Znext-solver" "-Cpanic=abort" "-L" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/traits/const-traits/minicore-drop-without-feature-gate.yes/auxiliary"
stdout: none
--- stderr -------------------------------
error: the `rustc_trivial_field_reads` attribute cannot be used on traits
##[error]  --> /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs:448:3
   |
---

warning: unused variable: `x`
##[warning]  --> /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs:52:9
   |
LL |     let x = 42_i32 + 43_i32;
   |         ^ help: if this is intentional, prefix it with an underscore: `_x`

warning: unused variable: `x`
##[warning]  --> /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs:56:9
   |
LL |     let x = 42_i32 + 43_i32;
   |         ^ help: if this is intentional, prefix it with an underscore: `_x`

warning: unused variable: `bytes`
##[warning]  --> /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs:149:28
   |
LL |     const fn from_ne_bytes(bytes: [u8; size_of::<Self>()]) -> Self {
   |                            ^^^^^ help: if this is intentional, prefix it with an underscore: `_bytes`

warning: unused variable: `other`
##[warning]  --> /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs:319:18
   |
LL |     fn eq(&self, other: &str) -> bool {
   |                  ^^^^^ help: if this is intentional, prefix it with an underscore: `_other`

warning: unused variable: `value`
##[warning]  --> /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs:417:18
   |
LL |     const fn new(value: T) -> RefCell<T> {
---
---- [ui] tests/ui/traits/const-traits/minicore-works.rs stdout ----

error: auxiliary build of /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs failed to compile: 
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2" "--target=aarch64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--out-dir" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/traits/const-traits/minicore-works/auxiliary" "-A" "internal_features" "-A" "incomplete_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/aarch64-unknown-linux-gnu/native/rust-test-helpers" "-Znext-solver" "-Cpanic=abort" "-L" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/traits/const-traits/minicore-works/auxiliary"
stdout: none
--- stderr -------------------------------
error: the `rustc_trivial_field_reads` attribute cannot be used on traits
##[error]  --> /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs:448:3
   |
---

warning: unused variable: `x`
##[warning]  --> /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs:52:9
   |
LL |     let x = 42_i32 + 43_i32;
   |         ^ help: if this is intentional, prefix it with an underscore: `_x`

warning: unused variable: `x`
##[warning]  --> /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs:56:9
   |
LL |     let x = 42_i32 + 43_i32;
   |         ^ help: if this is intentional, prefix it with an underscore: `_x`

warning: unused variable: `bytes`
##[warning]  --> /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs:149:28
   |
LL |     const fn from_ne_bytes(bytes: [u8; size_of::<Self>()]) -> Self {
   |                            ^^^^^ help: if this is intentional, prefix it with an underscore: `_bytes`

warning: unused variable: `other`
##[warning]  --> /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs:319:18
   |
LL |     fn eq(&self, other: &str) -> bool {
   |                  ^^^^^ help: if this is intentional, prefix it with an underscore: `_other`

warning: unused variable: `value`
##[warning]  --> /checkout/tests/ui/traits/const-traits/auxiliary/minicore.rs:417:18
   |
LL |     const fn new(value: T) -> RefCell<T> {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mejrs mejrs

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@josetorrs @rust-log-analyzer @rustbot @mejrs