Improve MaybeLiveLocals - #160672
Open
nnethercote wants to merge 7 commits into
Open
Conversation
It's mostly identical to `MaybeLiveLocals`, and we can delegate most of its operations to `MaybeLiveLocals`. Note that there was a tiny difference between `MaybeLiveLocals::apply_call_return_effect` and `MaybeTransitiveLiveLocals::apply_call_return_effect`: the former uses `state.kill(local)`, the latter used `state.remove(local)`. The two are equivalent so the difference didn't matter, but it does demonstrate the dangers of the code duplication.
As `LivenessTransferFunction`. This avoids renaming it via a `use` item, which makes things clearer.
It has only two uses, and it's just a synonym for `LivenessTransferFunction`, which has more uses.
Collaborator
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
rustbot
added
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details in individual commits.
r? @cjgillot