Add regression test for cross-crate assoc const private field leak in rustdoc - #160748
Open
zakrad wants to merge 1 commit into
Open
Add regression test for cross-crate assoc const private field leak in rustdoc#160748zakrad wants to merge 1 commit into
zakrad wants to merge 1 commit into
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @GuillaumeGomez. Use Why was this reviewer chosen?The reviewer was selected based on:
|
| extern crate assoc_const_private_fields; | ||
|
|
||
| //@ has foo/struct.HasPrivateFields.html | ||
| //@ has - '//*[@id="associatedconstant.ASSOC"]' 'pub const ASSOC: HasPrivateFields' |
Member
There was a problem hiding this comment.
Can you use a regex instead to ensure it's the entire content and not just a sub-part? So you use ^ at the start and $ at the end to ensure it's the full content.
Contributor
Author
There was a problem hiding this comment.
Thanks for hint, switched to regex
|
|
||
| //@ has foo/struct.HasPrivateFields.html | ||
| //@ has - '//*[@id="associatedconstant.ASSOC"]' 'pub const ASSOC: HasPrivateFields' | ||
| //@ !has - '//*[@id="associatedconstant.ASSOC"]' '_private' |
Member
There was a problem hiding this comment.
Once updated to the regex, please remove this check.
GuillaumeGomez
approved these changes
Aug 8, 2026
Member
|
Thanks! r=me once CI pass. @bors delegate+ |
Contributor
|
✌️ @zakrad, you can now approve this pull request! If @GuillaumeGomez told you to " |
Contributor
Author
|
@bors r=GuillaumeGomez |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Aug 9, 2026
…eGomez Add regression test for cross-crate assoc const private field leak in rustdoc Closes rust-lang#99630 adds a rustdoc test, reexporting a type must not leak the private field
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 9, 2026
Rollup of 6 pull requests Successful merges: - #160529 (Upgrade and deduplicate dependencies) - #158517 (Initial implementation of named `Fn` trait parameters) - #158587 (check if len of array const arg matches the expected len of the type when lowering to valtree) - #160748 (Add regression test for cross-crate assoc const private field leak in rustdoc) - #160708 (remove old update mechanism) - #160768 (Fix autodiff_illegal.rs test)
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Aug 9, 2026
…eGomez Add regression test for cross-crate assoc const private field leak in rustdoc Closes rust-lang#99630 adds a rustdoc test, reexporting a type must not leak the private field
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #99630 adds a rustdoc test, reexporting a type must not leak the private field