Unify E0117 foreign-trait label for ADT/primitive types with existing Slice/Array/Tuple handling - #160767
Open
Omar1H1 wants to merge 1 commit into
Open
Unify E0117 foreign-trait label for ADT/primitive types with existing Slice/Array/Tuple handling#160767Omar1H1 wants to merge 1 commit into
Omar1H1 wants to merge 1 commit into
Conversation
… orphan check
`emit_orphan_check_error` already special-cases non-local types that
appear in a foreign trait's own parameter position (as opposed to
Self): for Slice, Array, and Tuple, the label reads "this is
not defined in the current crate because this is a foreign trait"
instead of naming the type. The Adt arm and the primitive/catch-all
arm never checked this and always named the type instead, even in the
same non-Self position.
This produced a confusing diagnostic for impls like
impl PartialEq for u32 {}
where Rhs defaults to Self (u32), so both the Self label and
the Rhs label read `u32` is not defined in the current crate,
with the second one visually landing under PartialEq since the
defaulted Rhs has no span of its own.
Extend the existing is_foreign check to the Adt and catch-all arms
so all four cases behave consistently.
Addresses rust-lang#160648
Collaborator
|
Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @petrochenkov (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
Why was this reviewer chosen?The reviewer was selected based on:
|
Collaborator
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
emit_orphan_check_error(incompiler/rustc_hir_analysis/src/coherence/orphan.rs) already has anis_foreignflag, true whenever a non-local type sits in one of the trait's own parameter positions rather thanSelf. TheSlice,Array, andTuplearms already use it to switch their label to a generic "this is not defined in the current crate because this is a foreign trait" message instead of naming the type. TheAdtarm and the catch-all_arm (covering primitives) never checkedis_foreignand always named the type, even in the same non-Self position.This PR extends the same
is_foreignbranch to those two arms, so all four are consistent. No new types or subdiagnostics reuses the existingOnlyCurrentTraitsForeignstruct already used a few lines above.LLM use :
I used LLM to explore the project and find where code that tags labels
Before / after
Before :
After :
Addresses #160648
r? compiler