parser diagnostics: Suggest adding a body for a match arm followed by a comma - #160787
Open
jakubadamw wants to merge 1 commit into
Open
parser diagnostics: Suggest adding a body for a match arm followed by a comma#160787jakubadamw wants to merge 1 commit into
jakubadamw wants to merge 1 commit into
Conversation
Only suggest a tuple or an or-pattern when the comma-separated patterns are followed by a `=>` or a guard. Otherwise the arm is just missing a body, which `parse_arm` already reports.
Collaborator
|
The parser was modified, potentially altering the grammar of (stable) Rust cc @fmease |
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @dingxiangfei2009. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parser diagnostics: only suggest a tuple or an or-pattern when the comma-separated patterns are followed by a
=>or a guard. Otherwise the arm is just missing a body, which will then be reported byparse_arm.No new tests, because existing tests cover this, I’ve extended with one more specific example and updated their expected results.
Closes #159686.