Updates the expect messages in library/std/src/net/udp.rs to follow the style guide. Related issue: #159751 - #160821
Open
jaroslawroszyk wants to merge 1 commit into
Open
Updates the expect messages in library/std/src/net/udp.rs to follow the style guide. Related issue: #159751#160821jaroslawroszyk wants to merge 1 commit into
jaroslawroszyk wants to merge 1 commit into
Conversation
Updates the expect messages in library/std/src/net/udp.rs to follow the style guide.
rustbot
added
S-waiting-on-review
Collaborator
|
r? @clarfonthey rustbot has assigned @clarfonthey. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Collaborator
|
jaroslawroszyk
changed the title
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot)Important For more information how to resolve CI failures of this job, visit this link. |
clarfonthey
reviewed
Aug 9, 2026
| /// let socket = UdpSocket::bind("127.0.0.1:34254").expect("couldn't bind to address"); | ||
| /// let socket_clone = socket.try_clone().expect("couldn't clone the socket"); | ||
| /// let socket = UdpSocket::bind("127.0.0.1:34254").expect("bind should succeed"); | ||
| /// let socket_clone = socket.try_clone().expect("clone should succeed"); |
Contributor
There was a problem hiding this comment.
Suggested change
| /// let socket_clone = socket.try_clone().expect("clone should succeed"); | |
| /// let socket_clone = socket.try_clone().expect("try_clone should succeed"); |
Contributor
|
CI failure appears spurious. If you fix the commit messages to remove the reference to the issue, and also make the minor change I suggest, this looks good to me. Thank you! (That is, r=me once those are fixed.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #159751