Rollup of 10 pull requests - #160849
Merged
Merged
Conversation
Example
---
```rust
fn f() { let a: () = (); let b: () = todo$0!() }
```
**Before this PR**
```text
1. Inline macro
2. Replace todo!() with a
3. Replace todo!() with ()
4. Replace todo!() with f()
```
**After this PR**
```text
1. Inline macro
```
Visit them in the visitor. Also fix some missing things in the visiting infra.
This way we don't need to re-retrieve it every time, saving time and memory.
…threaded rayon pool This reduces variance, although not completely.
…s-no-parallell internal: When running `analysis-stats` without `--parallel`, install a single-threaded rayon pool
…-warning minor: Add a warning to the docs of `InvocationStrategy::Once`
fix: Add `-Zjson-target-spec` on Cargo calls where needed
…t-scope fix: Fix `ExprScopes` handling of exprs inside patterns
Update salsa to 0.28
fix: exclude unknown types from term search
rustbot
added
S-waiting-on-review
Contributor
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 10, 2026
Rollup of 10 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple-1 try-job: aarch64-apple-2 try-job: x86_64-mingw-1 try-job: i686-msvc-1 try-job: i686-msvc-2
This comment has been minimized.
This comment has been minimized.
Contributor
rust-bors
Bot
added
merged-by-bors
Contributor
This was referenced Aug 10, 2026
Collaborator
|
📌 Perf builds for each rolled up PR:
previous master: 7088e4b63a In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 7088e4b (parent) -> ea06042 (this PR) Test differencesShow 242 test diffsStage 0
Stage 1
Stage 2
(and 104 additional test diffs) Additionally, 38 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard ea060423749bf6e561c3398f403425c502beb9ba --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (ea06042): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)Results (primary 3.0%, secondary 1.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 0.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 455.179s -> 453.486s (-0.37%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
rust-analyzersubtree update #160841 (rust-analyzersubtree update)analysisarg fromResultsVisitormethods #160833 (Removeanalysisarg fromResultsVisitormethods)io::Read#160836 (Fix swapped documentation lines onio::Read)SmallCopyListtoSmallCopySet#160840 (RenameSmallCopyListtoSmallCopySet)r? @ghost
Create a similar rollup