Add back homu-ignore markers around the PR template - #160872
Conversation
|
r? @jieyouxu rustbot has assigned @jieyouxu. Use Why was this reviewer chosen?The reviewer was selected based on:
|
88dee8f to
775d38b
Compare
Also clarify how the homu-ignore markers actually work.
775d38b to
0bcefa1
Compare
|
I've fixed the (8) affected open PRs manually for now.1 Will do that a second time once this is merged. (I've also fixed a handful of older cases based on the previous version of the template, where authors had accidentally removed the Footnotes
|
|
@bors p=1 note="can be rolled up, just noisy in git commit history" |
Rollup of 6 pull requests Successful merges: - #160872 (Add back homu-ignore markers around the PR template) - #160432 (core: generalize `BorrowedCursor::ensure_init`) - #160843 (Overhaul `rustc_query_impl`) - #160865 (use `static` instead of `const` for derive(Debug)) - #160866 (Update books) - #160881 (Implement <OnceCell,OnceLock>::new_init)
Rollup merge of #160872 - steffahn:put_back_homu-ignore, r=jieyouxu Add back homu-ignore markers around the PR template Besides reinstantiating the `homu-ignore` markers from #126501, this PR also adds better clarification how the homu-ignore markers actually work; I've then also moved that section further down as it seems less important than the other parts of the PR template message. (We shouldn't forget that this is a *general PR template message*, not a LLM-policy-specific message.) The disclosure markers appear to have been accidentally removed together with the checkboxes in #160785. In the future, if support for ignoring HTML comments in places such as markdown code blocks was added, the new description about how `<!-- homu-ignore:end -->`/`<!-- homu-ignore:start -->` can be used could be further simplified[^1], but I'd like to address the immediate issues first before considering any more involved improvements (there already *exist* [currently ~~6~~ 8] new PRs now that contain the whole template comment without `homu-ignore` markers). [^1]: actually it may always stay non-ideal given that HTML comments don't nest 🫠
|
I've manually fixed 2 more PRs' descriptions now so it's all handled, good to have gotten this merged so quickly ^^ - thanks @jieyouxu (Another 5 new PRs were already opened since, at the time of this writing, that benefitted from this so far, as those now do contain the comments properly guarded again.) |
|
As for unfixed "broken" cases that got through: 6 cases1 of LLM checkboxes made it into git history, 4 of which contain unmatched No case of the Footnotes
|
Besides reinstantiating the
homu-ignoremarkers from #126501, this PR also adds better clarification how the homu-ignore markers actually work; I've then also moved that section further down as it seems less important than the other parts of the PR template message. (We shouldn't forget that this is a general PR template message, not a LLM-policy-specific message.)The disclosure markers appear to have been accidentally removed together with the checkboxes in #160785.
In the future, if support for ignoring HTML comments in places such as markdown code blocks was added, the new description about how
<!-- homu-ignore:end -->/<!-- homu-ignore:start -->can be used could be further simplified1, but I'd like to address the immediate issues first before considering any more involved improvements (there already exist [currently68] new PRs now that contain the whole template comment withouthomu-ignoremarkers).Footnotes
actually it may always stay non-ideal given that HTML comments don't nest 🫠 ↩