rustdoc: accept attribute@ disambiguator for attribute macros - #160903
rustdoc: accept attribute@ disambiguator for attribute macros#160903sankalpsthakur wants to merge 1 commit into
attribute@ disambiguator for attribute macros#160903Conversation
Rustdoc already suggested `attribute@` for attribute macros, but parsing rejected it as unknown. Accept the prefix (symmetric with `derive@`) and document it so the suggestion produces valid links. Fixes rust-lang#159771 Signed-off-by: Sankalp Thakur <sankalphimself@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
|
Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @notriddle (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
Why was this reviewer chosen?The reviewer was selected based on:
|
|
|
Hi, For the last few months we have been receiving an increased amount of LLM generated contributions. We have no way to distinguish your PR from other generated ones and thus unfortunately need to put some additional barriers for contributions in your way. We are a community of contributors, not just a code repository. We focus on contributors who desire to stay around and put in the work to produce high quality contributions or learn to do so. We are thus restricting you (unfortunately github only offers bans as a method for this) as per our policies (1) and contribution standards (2) to from creating PRs and comments. To make sure you can learn how to contribute and get your ability to comment and create PRs reinstated, we invite you to join https://rust-lang.zulipchat.com/join/rlfvpemsaacs3pfi6kwqnqjb/ and start a thread asking for a mentor, who will then ask us to lift the restrictions. Thanks for understanding Oli in the name of the mod team |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Summary
Rustdoc already suggested
attribute@when an intra-doc link resolved to an attribute macro with the wrong kind (for exampleexample!), butDisambiguator::from_strdid not recognizeattribute, so applying the suggestion producedunknown disambiguator \attribute``.This change:
attribute@as a kind disambiguator forMacroKinds::ATTR(symmetric with existingderive@)Validation
./x.py test tests/rustdoc-ui --stage 1(or the relevant rustdoc jobs).Fixes #159771
AI/LLM disclosure