Skip to content

tests/run-make-cargo/thumb-none-cortex-m: bump cortex-m dependency - #160909

Open
japaric wants to merge 1 commit into
rust-lang:mainfrom
ferrocene:ja/bump-cortex-m-version
Open

tests/run-make-cargo/thumb-none-cortex-m: bump cortex-m dependency#160909
japaric wants to merge 1 commit into
rust-lang:mainfrom
ferrocene:ja/bump-cortex-m-version

Conversation

@japaric

@japaric japaric commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

the previous version, v0.5.0 (from 2018), does not include a Cargo lockfile which makes the test brittle as bugs and unintentional breaking changes in any new release of a dependency can make the test fail

the newly chosen version, v0.7.7, includes a Cargo lockfile

fixes #160907

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 11, 2026
@rustbot

rustbot commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

r? @mejrs

rustbot has assigned @mejrs.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 18 candidates

@rustbot

This comment has been minimized.

the previous version, v0.5.0 (from 2018), does not include a
Cargo lockfile which makes the test brittle as bugs and unintentional
breaking changes in any new release of a dependency can make the test fail

the newly chosen version, v0.7.7, includes a Cargo lockfile
@japaric
japaric force-pushed the ja/bump-cortex-m-version branch from f166505 to 91de2e3 Compare August 11, 2026 12:50

@mejrs mejrs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rust-bors

rust-bors Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 91de2e3 has been approved by mejrs

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 11, 2026
…, r=mejrs

tests/run-make-cargo/thumb-none-cortex-m: bump `cortex-m` dependency

the previous version, v0.5.0 (from 2018), does not include a Cargo lockfile which makes the test brittle as bugs and unintentional breaking changes in any new release of a dependency can make the test fail

the newly chosen version, v0.7.7, includes a Cargo lockfile

fixes rust-lang#160907
rust-bors Bot pushed a commit that referenced this pull request Aug 11, 2026
…uwer

Rollup of 10 pull requests

Successful merges:

 - #160620 (Do not pass `-no-pie` on Windows)
 - #160731 (Arc: Remove unnecessary fmt::Display use for overflow assertion)
 - #160760 (Miri: give the incremental session a chance to finish)
 - #160854 (Add -Zwasm-proc-macros flag)
 - #160868 (std: Adjust cfgs again for TLS on WASI)
 - #160894 (Allow running an arbitrary number of try jobs per PR)
 - #160790 (rustc-book: update sys-v abi link)
 - #160878 (Add rust_analyzer to check-cfg names)
 - #160909 (tests/run-make-cargo/thumb-none-cortex-m: bump `cortex-m` dependency)
 - #160920 (No longer mention the removed generic)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 11, 2026
…, r=mejrs

tests/run-make-cargo/thumb-none-cortex-m: bump `cortex-m` dependency

the previous version, v0.5.0 (from 2018), does not include a Cargo lockfile which makes the test brittle as bugs and unintentional breaking changes in any new release of a dependency can make the test fail

the newly chosen version, v0.7.7, includes a Cargo lockfile

fixes rust-lang#160907
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tests/run-make-cargo/thumb-none-cortex-m does not lock Cargo dependencies and can break

3 participants