Tiny readability cleanups for initialization dataflow analyses - #160995
Open
lqd wants to merge 3 commits into
Open
Tiny readability cleanups for initialization dataflow analyses#160995lqd wants to merge 3 commits into
lqd wants to merge 3 commits into
Conversation
to help readability, regroup all the impls for each analysis together, instead of randomly scattering them in the module.
some analysis impls didn't follow the patterns that all others did: - only constructors need to specify 'a - the functions that don't need 'a are grouped in their own impl
- add some documentation - at use sites, downgrade asserts we don't need, for an argument we don't use. we could also remove the argument, there's a single use site that uses it.
rustbot
added
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reading over borrowck liveness, I noticed this handful of small things in the dataflow initialization module.
They're easier to see per-commit but:
r? @jackh726