resolving cyclic glob vis-max - #161024
Open
calvinrp wants to merge 1 commit into
Open
Conversation
rustbot
added
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #160685
#159039 follows
ambiguity_vis_max. Mutual globs can cycle that and overflow the stack. Visit each most-visible glob once, and still walksource_declso it stays public.Also shortened the #159038 regression-test headers.
r? petrochenkov
@rustbot label +A-resolve +A-visibility +T-compiler +beta-nominated
LLM helped investigate and simplify. I wrote the change and this text.