Skip to content

ping me when target ABI checks are being changed - #161198

Open
RalfJung wants to merge 2 commits into
rust-lang:mainfrom
RalfJung:target-checks
Open

ping me when target ABI checks are being changed#161198
RalfJung wants to merge 2 commits into
rust-lang:mainfrom
RalfJung:target-checks

Conversation

@RalfJung

Copy link
Copy Markdown
Member

The first commit moves the target checks into a separate file, so that the second commit can set up triagebot to ping me when that file gets changed.

@rustbot

rustbot commented Aug 16, 2026

Copy link
Copy Markdown
Collaborator

These commits modify compiler targets.
(See the Target Tier Policy.)

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 16, 2026
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 16, 2026
@rustbot

rustbot commented Aug 16, 2026

Copy link
Copy Markdown
Collaborator

r? @chenyukang

rustbot has assigned @chenyukang.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 19 candidates

Comment thread triagebot.toml
cc = ["@oli-obk", "@celinval", "@ouz-a", "@makai410"]

[mentions."compiler/rustc_target/src/spec"]
[mentions."compiler/rustc_target/src/spec/targets"]

@RalfJung RalfJung Aug 16, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure why this message is printed even when we just change the infrastructure around targets, but do not change any actual target. I think checking just the targets folder is enough.
Cc @ehuss
(#103605)

View changes since the review

@chenyukang

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors

rust-bors Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 41e670d has been approved by chenyukang

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants