Analysis cleanups - #161203
Open
nnethercote wants to merge 3 commits into
Open
Conversation
For `Call` and `InlineAsm` we currently pass `pred` to `apply_call_return_effect`, but for `Yield` we pass `block`. This appears to be a copy/paste error. This currently has no effect because no existing backward analyses look at this argument, but it's worth fixing. There's also a similar case in graphviz.rs.
The edge computation for `Call`, `InlineAsm`, and `Yield` exactly duplicates what is done by `TerminatorKind::edges()`. This commit changes it to use `edges()`; this makes the backward analysis more similar to the forward analysis, which also matches on `TerminatorEdges`. Note: the bug fixed in the previous commit would have been less likely with this new code.
It doesn't need to be `mut`.
rustbot
added
S-waiting-on-review
Contributor
Author
|
LLM disclosure: an LLM found these when directed to look for simplifications. I wrote all the code and text changes myself. |
Contributor
|
@bors r+ |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Aug 17, 2026
…jgillot Analysis cleanups Three small dataflow analysis cleanups. Details in individual commits. r? @cjgillot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small dataflow analysis cleanups. Details in individual commits.
r? @cjgillot