Skip to content

Update LLVM submodule - #162133

Open
nikic wants to merge 1 commit into
rust-lang:mainfrom
nikic:llvm-23.1.0
Open

Update LLVM submodule#162133
nikic wants to merge 1 commit into
rust-lang:mainfrom
nikic:llvm-23.1.0

Conversation

@nikic

@nikic nikic commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Update to current release/23.x, which is a bit past the LLVM 23.1.0 release.

Fixes #161336.

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 1, 2026
@rustbot

rustbot commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @cuviper

@rustbot

rustbot commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

⚠️ Warning ⚠️

@nikic nikic added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 1, 2026
@nikic

nikic commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

Beta nomination includes the previous update in #161466 as well. The LLVM 23 version on beta is very old at this point (I think from around rc1), and a lot of issues have since been fixed. We should avoid shipping pre-release LLVM on beta.

@nikic

nikic commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 1, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Sep 1, 2026
@rust-bors

rust-bors Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: fbd8c6c (fbd8c6cda15a2ca65dba0cfec46946092069d7a8)
Base parent: a433023 (a4330234a776684c36428d001721d0320d24dd77)

@rust-timer

This comment has been minimized.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (fbd8c6c): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.3% [0.3%, 0.3%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

Results (primary 0.8%, secondary -2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.2% [1.6%, 2.9%] 2
Regressions ❌
(secondary)
6.0% [3.9%, 8.1%] 2
Improvements ✅
(primary)
-2.0% [-2.0%, -2.0%] 1
Improvements ✅
(secondary)
-5.0% [-7.2%, -2.7%] 6
All ❌✅ (primary) 0.8% [-2.0%, 2.9%] 3

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 473.301s -> 475.129s (0.39%)
Artifact size: 400.69 MiB -> 402.63 MiB (0.48%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 1, 2026
@cuviper

cuviper commented Sep 1, 2026

Copy link
Copy Markdown
Member

@bors r+

@rust-bors

rust-bors Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 8e6d69e has been approved by cuviper

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 1, 2026
@JonathanBrouwer

JonathanBrouwer commented Sep 1, 2026

Copy link
Copy Markdown
Member

@bors rollup=never
Hmmm I don't think we should be rolling up LLVM updates, because of

May cause unclear regressions

Is otherwise dangerous to rollup: LLVM or code generation

https://forge.rust-lang.org/compiler/reviews.html#rollups

@tgross35

tgross35 commented Sep 1, 2026

Copy link
Copy Markdown
Member

@bors p=1 submodule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. beta-nominated Nominated for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ICE]: rustc nightly SIGSEGV in llvm::LiveRange::join with -C opt-level=2

6 participants