bootstrap: Fix broken path for ./x doc compiler/rustc --open - #162318
Open
Zalathar wants to merge 1 commit into
Open
bootstrap: Fix broken path for ./x doc compiler/rustc --open#162318Zalathar wants to merge 1 commit into
./x doc compiler/rustc --open#162318Zalathar wants to merge 1 commit into
Conversation
Currently this fails because the correct path contains `rustc_main`, but bootstrap tries to open a nonexistent path containing `rustc-main` instead.
rustbot
added
S-waiting-on-review
Collaborator
|
|
Member
|
Thank you! @bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Sep 5, 2026
bootstrap: Fix broken path for `./x doc compiler/rustc --open` Currently this fails because the correct path contains `rustc_main`, but bootstrap tries to use a path containing `rustc-main` instead. The existing bug is amplified by the fact that currently doing `./x doc rustc_middle --open` for *any* compiler crate will instead document the entire compiler, and then try to open the docs for `rustc-main`, since it's the first crate in the crate list. With this fix, it is at least possible to view the resulting whole-compiler docs. r? Kobzol (or bootstrap)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently this fails because the correct path contains
rustc_main, but bootstrap tries to use a path containingrustc-maininstead.The existing bug is amplified by the fact that currently doing
./x doc rustc_middle --openfor any compiler crate will instead document the entire compiler, and then try to open the docs forrustc-main, since it's the first crate in the crate list.With this fix, it is at least possible to view the resulting whole-compiler docs.
r? Kobzol (or bootstrap)