Use correct dir_path when parsing module from path - #162363
Open
mu001999 wants to merge 2 commits into
Open
Conversation
rustbot
added
S-waiting-on-author
mu001999
marked this pull request as ready for review
September 6, 2026 12:07
rustbot
added
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #162080
We previously used the incorrect
dir_path(which wasname, the parent ofname/mod.rs, in this case), and then joined it withname/mod.rsagain, resulting inname/name/mod.rs.The first commit adds the regression test and snapshot of current behavior, the second commit fixes it.
r? petrochenkov