add test ensuring we refuse to const-eval the body of a rustc_do_not_const_check function - #162379
Open
RalfJung wants to merge 1 commit into
Open
add test ensuring we refuse to const-eval the body of a rustc_do_not_const_check function#162379RalfJung wants to merge 1 commit into
RalfJung wants to merge 1 commit into
Conversation
…const_check function
rustbot
added
S-waiting-on-review
Collaborator
|
|
oli-obk
approved these changes
Sep 7, 2026
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Sep 7, 2026
… r=oli-obk add test ensuring we refuse to const-eval the body of a rustc_do_not_const_check function IMO this is crucial, to ensure that we cannot break users by changing the body of such a function to something no-longer-const-compatible. r? @oli-obk
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Sep 7, 2026
… r=oli-obk add test ensuring we refuse to const-eval the body of a rustc_do_not_const_check function IMO this is crucial, to ensure that we cannot break users by changing the body of such a function to something no-longer-const-compatible. r? @oli-obk
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Sep 7, 2026
… r=oli-obk add test ensuring we refuse to const-eval the body of a rustc_do_not_const_check function IMO this is crucial, to ensure that we cannot break users by changing the body of such a function to something no-longer-const-compatible. r? @oli-obk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMO this is crucial, to ensure that we cannot break users by changing the body of such a function to something no-longer-const-compatible.
r? @oli-obk