Skip to content

defer next-solver normalization obligations in type ops - #162380

Open
amirHdev wants to merge 2 commits into
rust-lang:mainfrom
amirHdev:borrowck-normalize-fnsig-rpit-hrtb
Open

defer next-solver normalization obligations in type ops#162380
amirHdev wants to merge 2 commits into
rust-lang:mainfrom
amirHdev:borrowck-normalize-fnsig-rpit-hrtb

Conversation

@amirHdev

@amirHdev amirHdev commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

fixes #162323

With the next solver ambiguous projection goals can remain as obligations. type_op normalization now preserves these obligations instead of treating them as normalization failure

Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Sep 6, 2026
Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>
@amirHdev
amirHdev force-pushed the borrowck-normalize-fnsig-rpit-hrtb branch from fadb1f8 to a9a2c8d Compare September 7, 2026 09:43
@amirHdev

amirHdev commented Sep 7, 2026

Copy link
Copy Markdown
Contributor Author

A change worth noting is for next-solver type-op normalization the ambiguous projection goals are now deferred to fulfillment instead of failing during normalization and this may move some diagnostics later in the pipeline

@amirHdev
amirHdev marked this pull request as ready for review September 7, 2026 10:06
@rustbot

rustbot commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 7, 2026
@rustbot

rustbot commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

r? @mati865

rustbot has assigned @mati865.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 21 candidates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ICE]: error performing operation: fully_perform: triggered by a sealed supertrait + associated-type-bound subtraits

3 participants