[BENCH] remove CacheCell and CacheRefCell aliases and directly use Lock and RwLock - #162418
[BENCH] remove CacheCell and CacheRefCell aliases and directly use Lock and RwLock#162418LorrensP-2158466 wants to merge 1 commit into
CacheCell and CacheRefCell aliases and directly use Lock and RwLock#162418Conversation
… and `RwLock` instead in places that need synchronization
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
[BENCH] remove `CacheCell` and `CacheRefCell` aliases and directly use `Lock` and `RwLock`
|
Even if there are minor regressions, we can merge this once the concerns about locking in macro scope compression (#158845 (comment)) are resolved. |
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (798fc4c): comparison URL. Overall result: ❌✅ regressions and improvements - please read:Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf. Next, please: If you can, justify the regressions found in this try perf run in writing along with @bors rollup=never rustc-perf Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 2.0%, secondary 0.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 0.6%, secondary 5.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 478.991s -> 480.615s (0.34%) |
|
(The tokio benchmark was added today and might be a bit noisy at the start) |
Some changes from #158845 for benchmarking.
decided to change Mutex to
datastructures::sync::Lock.r? @petrochenkov