Skip to content

Replace links to github.com/rust-lang/rfcs with links to the Rust RFC Book - #162436

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
beetrees:rfcs-link-to-book
Sep 8, 2026
Merged

Replace links to github.com/rust-lang/rfcs with links to the Rust RFC Book#162436
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
beetrees:rfcs-link-to-book

Conversation

@beetrees

@beetrees beetrees commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

I noticed many error codes link to Rust RFCs via the source GitHub .md files instead of linking to the RFC Book. This PR updates those links to point to the RFC book - I also updated any other links to RFCs in the repo (not including subtrees) while I was at it.

@rustbot

rustbot commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

rustdoc-json-types is a public (although nightly-only) API. If possible, consider changing src/librustdoc/json/conversions.rs; otherwise, make sure you bump the FORMAT_VERSION constant.

cc @CraftSpider, @Enselic, @obi1kenobi

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Sep 7, 2026
@rustbot

rustbot commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

r? @mejrs

rustbot has assigned @mejrs.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 19 candidates

@mejrs mejrs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me once CI is green :)

@bors delegate+

View changes since this review

@rust-bors

rust-bors Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

✌️ @beetrees, you can now approve this pull request!

If @mejrs told you to "r=me" after making some further change, then please make that change and post @bors r=mejrs.

View changes since this delegation.

@JonathanBrouwer

Copy link
Copy Markdown
Member

@bors r=mejrs

@rust-bors

rust-bors Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

📌 Commit ac599d4 has been approved by mejrs

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 7, 2026
rust-bors Bot pushed a commit that referenced this pull request Sep 7, 2026
…uwer

Rollup of 5 pull requests

Successful merges:

 - #162436 (Replace links to `github.com/rust-lang/rfcs` with links to the Rust RFC Book)
 - #162438 (codegen_llvm: use minimum/maximum intrinsics now that they got fixed)
 - #161896 (Remove fields from TypeKind: Array, Slice)
 - #162276 (Avoid wrong suggestions for never type coerce)
 - #162421 (Raise a delayed bug when comparing incompatible constructors)
@rust-bors
rust-bors Bot merged commit ea913e9 into rust-lang:main Sep 8, 2026
13 checks passed
rust-bors Bot pushed a commit that referenced this pull request Sep 8, 2026
Rollup merge of #162436 - beetrees:rfcs-link-to-book, r=mejrs

Replace links to `github.com/rust-lang/rfcs` with links to the Rust RFC Book

I noticed many error codes link to Rust RFCs via the [source GitHub `.md` files](https://github.com/rust-lang/rfcs/tree/master/text) instead of linking to the [RFC Book](https://rust-lang.github.io/rfcs/). This PR updates those links to point to the RFC book - I also updated any other links to RFCs in the repo (not including subtrees) while I was at it.
@rustbot rustbot added this to the 1.100.0 milestone Sep 8, 2026
@beetrees
beetrees deleted the rfcs-link-to-book branch September 8, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-run-make Area: port run-make Makefiles to rmake.rs A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants