Implement semantic analysis for named fn trait params - #162634
Open
JonathanBrouwer wants to merge 8 commits into
Open
Implement semantic analysis for named fn trait params#162634JonathanBrouwer wants to merge 8 commits into
JonathanBrouwer wants to merge 8 commits into
Conversation
While the stderrs in this commit are neutral, some better some worse, there were quite a few bad diagnostics if we enable `recover_arg_parse` for parenthesized argument lists
JonathanBrouwer
added
the
F-named_fn_trait_parameters
Collaborator
|
The parser was modified, potentially altering the grammar of (stable) Rust cc @fmease |
rustbot
added
S-waiting-on-review
Collaborator
|
r? @folkertdev rustbot has assigned @folkertdev. Use Why was this reviewer chosen?The reviewer was selected based on:
|
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR can be reviewed commit by commit.
Every commit passes uitests individually.
The goal of this PR is to make the semantic of named fn trait parameters match those of
fnpointers, which is what was decided on the RFC: rust-lang/rfcs#3955.This is achieved, which can be observed by the fact that the output of the
named-fn-trait-params.rstest matches that offn-ptr-pattern.rs.This PR also marks the feature as complete.
Tracking issue: #158499