Suggest changing argument mutability from &T to &mut T - #162657
Open
enesmahmtoglu wants to merge 1 commit into
Open
Suggest changing argument mutability from &T to &mut T#162657enesmahmtoglu wants to merge 1 commit into
&T to &mut T#162657enesmahmtoglu wants to merge 1 commit into
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
Thanks for the pull request, and welcome! The Rust Project has assigned @ShoyuVanilla (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks. Please see the contribution instructions and our LLM policy for more information. Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
When a function or method takes a mutable reference but an immutable reference is provided, suggest changing the borrow to be mutable.
enesmahmtoglu
force-pushed
the
suggest-changing-argument-mutability
branch
from
September 11, 2026 17:34
d186516 to
bf137d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #159490.
When a function or method takes a mutable reference
&mut Tbut an immutable reference&Tis supplied (e.g.read_line(&input)), rustc reportstypes differ in mutabilitybut did not provide a suggestion to change the borrow.This commit adds a diagnostic suggestion in
rustc_hir_typeckto change the borrow to mutable (&mut ...), along with a new UI regression test.