add debuginfo for unboxed closures#17184
Closed
nathantypanski wants to merge 1 commit intorust-lang:masterfrom
Closed
add debuginfo for unboxed closures#17184nathantypanski wants to merge 1 commit intorust-lang:masterfrom
nathantypanski wants to merge 1 commit intorust-lang:masterfrom
Conversation
This catches two unhandled patterns in middle/trans/debuginfo.rs where a ty::ty_unboxed_closure could show up, preventing various potential ICEs when #[feature(unboxed_closures)] is used with `-g`. It also updates the test case from rust-lang#17093 in response to new information from rust-lang#17021 showing that the test still caused an ICE when compiling with debuginfo. Closes rust-lang#17021.
Contributor
Author
|
This isn't ready for merge just yet (still test case failures). I'll update the PR and maybe poke my head into IRC when it's better. |
Contributor
Author
|
Closing this until I figure it out or something better pops up. I'm not making progress on these errors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This catches two unhandled patterns in middle/trans/debuginfo.rs where a
ty::ty_unboxed_closure could show up, preventing various potential ICEs
when #[feature(unboxed_closures)] is used with
-g.It also updates the test case from #17093 in response to new information
from #17021 showing that the test still caused an ICE when compiling
with debuginfo.
Closes #17021.