Incoming #2706
Merged
Incoming #2706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The same dtor was getting re-used for different instances, which didn't always work right. Fixed.
It wasn't possible to refer to the constructor for a class nested inside an item from the class's outer scope. Fixed.
The fix in 208621 means you now can't shadow a class name with a local, which is consistent with other behavior. But stackwalk was doing that. Fixed it.
Irritatingly, class dtors have a different type from resource dtors (because class dtors have a self argument), and the monomorphic case wasn't reflecting that. Fixed.
Ports now are represented internally as classes.
Related to issue #2657, but this is not a complete fix.
The first benchmark shows about twice the throughput of the old system.
This reverts commit 290206b. Forgot to add the actual native code, temporarily reverting.
A cleaner way to handle suffix inference for unary minus exprs.
…f field This was a call to span_bug() before. I'm not sure about the other cases, but the test case shows that the `vk_self` case can certainly arise with a bad program, so it should be a span_err() thing and not a span_bug() thing. Closes #2590
issue-912 is xfailed. issue-2111 is already fixed, but it's good to have the test case.
brson
added a commit
that referenced
this pull request
Jun 22, 2012
celinval
added a commit
to celinval/rust-dev
that referenced
this pull request
Jun 4, 2024
tshepang
added a commit
to tshepang/rust
that referenced
this pull request
Dec 23, 2025
Add Rustc Explore video link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.