Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add primitive module to libcore #67637

Open
wants to merge 1 commit into
base: master
from

Conversation

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Dec 26, 2019

This re-exports the primitive types from libcore at core::primitive to allow
macro authors to have a reliable location to use them from.

Fixes #44865

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member Author

Mark-Simulacrum commented Dec 26, 2019

cc @sgrif since you raised the issue

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Dec 26, 2019

The job mingw-check of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-12-26T17:59:50.3934284Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-26T17:59:50.4235386Z ##[command]git config gc.auto 0
2019-12-26T17:59:50.4316034Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-26T17:59:50.4373937Z ##[command]git config --get-all http.proxy
2019-12-26T17:59:50.4519251Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67637/merge:refs/remotes/pull/67637/merge
---
2019-12-26T18:05:29.3618118Z   local time: Thu Dec 26 18:05:29 UTC 2019
2019-12-26T18:05:29.6521844Z   network time: Thu, 26 Dec 2019 18:05:29 GMT
2019-12-26T18:05:29.6525377Z == end clock drift check ==
2019-12-26T18:05:38.4414663Z 
2019-12-26T18:05:38.4483912Z ##[error]Bash exited with code '1'.
2019-12-26T18:05:38.4514819Z ##[section]Starting: Checkout
2019-12-26T18:05:38.4517037Z ==============================================================================
2019-12-26T18:05:38.4517084Z Task         : Get sources
2019-12-26T18:05:38.4517245Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Copy link
Member

dtolnay left a comment

Thanks, this looks good to me.

Do we know how these get rendered by rustdoc? If they appear as pub type u8 = U8 then I think it's worth doing something about that before landing. I think ideally it should appear as pub use u8, similar to how non-doc(inline) reexports normally appear.

src/libcore/primitive.rs Outdated Show resolved Hide resolved
@Mark-Simulacrum Mark-Simulacrum force-pushed the Mark-Simulacrum:primitive-mod branch from a1a47ed to d59e54a Dec 26, 2019
@Mark-Simulacrum

This comment has been minimized.

Copy link
Member Author

Mark-Simulacrum commented Dec 26, 2019

I've force-pushed an update. It looks like rustdoc currently has a bug (it panics) when it attempts to inline the documentation from a pub use u8;.

To avoid that, we instead directly include the same primitive file twice via #[path = ... ] on the module declaration in std.

The rendering is as follows in both core and std, unfortunately we do not get hyperlinking to the primitive type docs in either location.

image

Copy link
Member

dtolnay left a comment

Nice, r=me once there is a tracking issue.

Could you also file a bug on rustdoc to get these hyperlinked and link to it from the tracking issue? It should work like the following which does get correctly hyperlinked:

#[doc(no_inline)]
pub use String;

Selection_141

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Dec 26, 2019

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-12-26T20:08:14.1172235Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-26T20:08:14.1189107Z ##[command]git config gc.auto 0
2019-12-26T20:08:14.1192513Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-26T20:08:14.1196184Z ##[command]git config --get-all http.proxy
2019-12-26T20:08:14.1198835Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67637/merge:refs/remotes/pull/67637/merge
---
2019-12-26T21:03:53.4518510Z .................................................................................................... 1600/9456
2019-12-26T21:03:58.2216570Z .................................................................................................... 1700/9456
2019-12-26T21:04:06.9387904Z .............................................................................................i...... 1800/9456
2019-12-26T21:04:14.5028007Z .................................................................................................... 1900/9456
2019-12-26T21:04:20.6224493Z ...............................................................................iiiii................ 2000/9456
2019-12-26T21:04:40.3142319Z .................................................................................................... 2200/9456
2019-12-26T21:04:42.5206493Z .................................................................................................... 2300/9456
2019-12-26T21:04:44.8338543Z .................................................................................................... 2400/9456
2019-12-26T21:04:50.4424702Z .................................................................................................... 2500/9456
---
2019-12-26T21:07:34.4070946Z ..........i...............i......................................................................... 4900/9456
2019-12-26T21:07:43.7818678Z .................................................................................................... 5000/9456
2019-12-26T21:07:48.4900667Z ......................................................i............................................. 5100/9456
2019-12-26T21:07:57.2712367Z .................................................................................................... 5200/9456
2019-12-26T21:08:03.0293000Z .....................ii.ii...........i.............................................................. 5300/9456
2019-12-26T21:08:11.2806965Z .................................................................................................... 5500/9456
2019-12-26T21:08:21.3339832Z .................................................................................................... 5600/9456
2019-12-26T21:08:27.9238112Z ...i................................................................................................ 5700/9456
2019-12-26T21:08:33.0867268Z .................................................................................................... 5800/9456
2019-12-26T21:08:33.0867268Z .................................................................................................... 5800/9456
2019-12-26T21:08:42.3050036Z ...........................................................................................ii...i..i 5900/9456
2019-12-26T21:08:53.8728540Z i...........i....................................................................................... 6000/9456
2019-12-26T21:09:09.7154580Z .................................................................................................... 6200/9456
2019-12-26T21:09:16.4082290Z .................................................................................................... 6300/9456
2019-12-26T21:09:16.4082290Z .................................................................................................... 6300/9456
2019-12-26T21:09:31.8639371Z ..................i..ii............................................................................. 6400/9456
2019-12-26T21:09:50.0025069Z ...............................................................................................i.... 6600/9456
2019-12-26T21:09:51.8808575Z .................................................................................................... 6700/9456
2019-12-26T21:09:54.0000298Z ...............................................................................................i.... 6800/9456
2019-12-26T21:09:56.4218202Z .................................................................................................... 6900/9456
---
2019-12-26T21:11:26.3424593Z .................................................................................................... 7500/9456
2019-12-26T21:11:30.8090525Z .......................................................F............................................ 7600/9456
2019-12-26T21:11:36.8890782Z .................................................................................................... 7700/9456
2019-12-26T21:11:47.5831107Z .................................................................................................... 7800/9456
2019-12-26T21:11:52.9279523Z ...........................iiii..................................................................... 7900/9456
2019-12-26T21:12:06.0117168Z .................................................................................................... 8100/9456
2019-12-26T21:12:14.8047232Z .................................................................................................... 8200/9456
2019-12-26T21:12:27.4031420Z .................................................................................................... 8300/9456
2019-12-26T21:12:34.1141879Z .................................................................................................... 8400/9456
---
2019-12-26T21:14:20.0646282Z 14   --> $DIR/resolve-primitive-fallback.rs:3:5
2019-12-26T21:14:20.0646647Z 
2019-12-26T21:14:20.0646811Z 
2019-12-26T21:14:20.0646955Z The actual stderr differed from the expected stderr.
2019-12-26T21:14:20.0647479Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/resolve/resolve-primitive-fallback/resolve-primitive-fallback.stderr
2019-12-26T21:14:20.0648302Z To update references, rerun the tests and pass the `--bless` flag
2019-12-26T21:14:20.0648722Z To only update this specific test, also pass `--test-args resolve/resolve-primitive-fallback.rs`
2019-12-26T21:14:20.0648980Z error: 1 errors occurred comparing output.
2019-12-26T21:14:20.0649111Z status: exit code: 1
2019-12-26T21:14:20.0649111Z status: exit code: 1
2019-12-26T21:14:20.0649950Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/resolve/resolve-primitive-fallback.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/resolve/resolve-primitive-fallback" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/resolve/resolve-primitive-fallback/auxiliary" "-A" "unused"
2019-12-26T21:14:20.0650462Z ------------------------------------------
2019-12-26T21:14:20.0650609Z 
2019-12-26T21:14:20.0650902Z ------------------------------------------
2019-12-26T21:14:20.0651039Z stderr:
---
2019-12-26T21:14:20.0657554Z ---- [ui] ui/shadow-bool.rs stdout ----
2019-12-26T21:14:20.0657863Z 
2019-12-26T21:14:20.0658154Z error: test compilation failed although it shouldn't!
2019-12-26T21:14:20.0658296Z status: exit code: 1
2019-12-26T21:14:20.0661807Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/shadow-bool.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/shadow-bool" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/shadow-bool/auxiliary" "-A" "unused"
2019-12-26T21:14:20.0662887Z ------------------------------------------
2019-12-26T21:14:20.0662916Z 
2019-12-26T21:14:20.0663085Z ------------------------------------------
2019-12-26T21:14:20.0663136Z stderr:
---
2019-12-26T21:14:20.0663767Z 
2019-12-26T21:14:20.0663827Z error[E0601]: `main` function not found in crate `shadow_bool`
2019-12-26T21:14:20.0664635Z   --> /checkout/src/test/ui/shadow-bool.rs:3:1
2019-12-26T21:14:20.0664690Z    |
2019-12-26T21:14:20.0664750Z LL | / mod bar {
2019-12-26T21:14:20.0664795Z LL | |     pub trait QueryId {
2019-12-26T21:14:20.0664843Z LL | |         const SOME_PROPERTY: bool;
2019-12-26T21:14:20.0664946Z ...  |
2019-12-26T21:14:20.0664993Z LL | |     const SOME_PROPERTY: core::primitive::bool = true;
2019-12-26T21:14:20.0665039Z LL | | }
2019-12-26T21:14:20.0665039Z LL | | }
2019-12-26T21:14:20.0665321Z    | |_^ consider adding a `main` function to `/checkout/src/test/ui/shadow-bool.rs`
2019-12-26T21:14:20.0665402Z error: aborting due to previous error
2019-12-26T21:14:20.0665432Z 
2019-12-26T21:14:20.0665700Z For more information about this error, try `rustc --explain E0601`.
2019-12-26T21:14:20.0665736Z 
---
2019-12-26T21:14:20.0667131Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:385:22
2019-12-26T21:14:20.0667190Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-12-26T21:14:20.0680721Z 
2019-12-26T21:14:20.0680801Z 
2019-12-26T21:14:20.0682359Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "7.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-12-26T21:14:20.0682646Z 
2019-12-26T21:14:20.0682669Z 
2019-12-26T21:14:20.0689699Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-12-26T21:14:20.0689937Z Build completed unsuccessfully in 0:59:42
2019-12-26T21:14:20.0689937Z Build completed unsuccessfully in 0:59:42
2019-12-26T21:14:20.0739096Z == clock drift check ==
2019-12-26T21:14:20.0756807Z   local time: Thu Dec 26 21:14:20 UTC 2019
2019-12-26T21:14:20.2298537Z   network time: Thu, 26 Dec 2019 21:14:20 GMT
2019-12-26T21:14:20.2298624Z == end clock drift check ==
2019-12-26T21:14:21.2017420Z 
2019-12-26T21:14:21.2107535Z ##[error]Bash exited with code '1'.
2019-12-26T21:14:21.2142778Z ##[section]Starting: Checkout
2019-12-26T21:14:21.2144822Z ==============================================================================
2019-12-26T21:14:21.2144881Z Task         : Get sources
2019-12-26T21:14:21.2144966Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Mark-Simulacrum Mark-Simulacrum force-pushed the Mark-Simulacrum:primitive-mod branch from d59e54a to 7c14f0f Dec 26, 2019
@Mark-Simulacrum

This comment has been minimized.

Copy link
Member Author

Mark-Simulacrum commented Dec 26, 2019

Hm, actually, now that these are re-exports, direct use is not going to trigger stability lints (e.g., the UI test added by this PR passes without a feature gate). Only use std::primitive; will; not even use std::primitive::bool would. Given that, I think feature gating this doesn't make too much sense, since we're not really gating any functionality, so I've dropped the feature gating in this PR.

We may want to FCP this as an insta-stable addition in that case.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Dec 26, 2019

The job mingw-check of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-12-26T21:27:29.1879888Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-26T21:27:29.2070781Z ##[command]git config gc.auto 0
2019-12-26T21:27:29.2174957Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-26T21:27:29.2217172Z ##[command]git config --get-all http.proxy
2019-12-26T21:27:29.2360937Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67637/merge:refs/remotes/pull/67637/merge
---
2019-12-26T21:33:00.8670617Z   local time: Thu Dec 26 21:33:00 UTC 2019
2019-12-26T21:33:01.4019416Z   network time: Thu, 26 Dec 2019 21:33:01 GMT
2019-12-26T21:33:01.4019619Z == end clock drift check ==
2019-12-26T21:33:16.3874912Z 
2019-12-26T21:33:16.3970968Z ##[error]Bash exited with code '1'.
2019-12-26T21:33:16.4029875Z ##[section]Starting: Checkout
2019-12-26T21:33:16.4031550Z ==============================================================================
2019-12-26T21:33:16.4031604Z Task         : Get sources
2019-12-26T21:33:16.4031650Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Mark-Simulacrum Mark-Simulacrum force-pushed the Mark-Simulacrum:primitive-mod branch from 7c14f0f to f5499a9 Dec 26, 2019
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Dec 26, 2019

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-12-26T22:11:23.3293161Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-26T22:11:23.3499736Z ##[command]git config gc.auto 0
2019-12-26T22:11:23.3580840Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-26T22:11:23.3644655Z ##[command]git config --get-all http.proxy
2019-12-26T22:11:23.3795182Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67637/merge:refs/remotes/pull/67637/merge
---
2019-12-26T23:10:52.8096041Z .................................................................................................... 1600/9456
2019-12-26T23:10:57.2323528Z .................................................................................................... 1700/9456
2019-12-26T23:11:06.0754509Z .............................................................................................i...... 1800/9456
2019-12-26T23:11:13.8418529Z .................................................................................................... 1900/9456
2019-12-26T23:11:20.1797793Z ...............................................................................iiiii................ 2000/9456
2019-12-26T23:11:40.7841922Z .................................................................................................... 2200/9456
2019-12-26T23:11:42.9173717Z .................................................................................................... 2300/9456
2019-12-26T23:11:45.1791860Z .................................................................................................... 2400/9456
2019-12-26T23:11:50.9628990Z .................................................................................................... 2500/9456
---
2019-12-26T23:14:41.6944527Z ..........i...............i......................................................................... 4900/9456
2019-12-26T23:14:51.1608939Z .................................................................................................... 5000/9456
2019-12-26T23:14:56.1167848Z ......................................................i............................................. 5100/9456
2019-12-26T23:15:05.1066329Z .................................................................................................... 5200/9456
2019-12-26T23:15:11.0174261Z .....................ii.ii...........i.............................................................. 5300/9456
2019-12-26T23:15:19.4197634Z .................................................................................................... 5500/9456
2019-12-26T23:15:29.9965126Z .................................................................................................... 5600/9456
2019-12-26T23:15:36.8988941Z ...i................................................................................................ 5700/9456
2019-12-26T23:15:42.3399537Z .................................................................................................... 5800/9456
2019-12-26T23:15:42.3399537Z .................................................................................................... 5800/9456
2019-12-26T23:15:52.2015236Z ...........................................................................................ii...i..i 5900/9456
2019-12-26T23:16:04.3047168Z i...........i....................................................................................... 6000/9456
2019-12-26T23:16:21.1406643Z .................................................................................................... 6200/9456
2019-12-26T23:16:28.1547135Z .................................................................................................... 6300/9456
2019-12-26T23:16:28.1547135Z .................................................................................................... 6300/9456
2019-12-26T23:16:42.7336314Z ..................i..ii............................................................................. 6400/9456
2019-12-26T23:17:01.8645243Z ...............................................................................................i.... 6600/9456
2019-12-26T23:17:03.8713937Z .................................................................................................... 6700/9456
2019-12-26T23:17:05.9324490Z ...............................................................................................i.... 6800/9456
2019-12-26T23:17:08.2984413Z .................................................................................................... 6900/9456
---
2019-12-26T23:18:42.4485967Z .................................................................................................... 7500/9456
2019-12-26T23:18:47.0182093Z .......................................................F............................................ 7600/9456
2019-12-26T23:18:53.3810272Z .................................................................................................... 7700/9456
2019-12-26T23:19:03.2194583Z .................................................................................................... 7800/9456
2019-12-26T23:19:09.4288692Z ..........................iiii...................................................................... 7900/9456
2019-12-26T23:19:23.2720987Z .................................................................................................... 8100/9456
2019-12-26T23:19:32.3203810Z .................................................................................................... 8200/9456
2019-12-26T23:19:45.2634922Z .................................................................................................... 8300/9456
2019-12-26T23:19:51.9624791Z .................................................................................................... 8400/9456
---
2019-12-26T23:21:40.7628630Z 14   --> $DIR/resolve-primitive-fallback.rs:3:5
2019-12-26T23:21:40.7629015Z 
2019-12-26T23:21:40.7629209Z 
2019-12-26T23:21:40.7629414Z The actual stderr differed from the expected stderr.
2019-12-26T23:21:40.7629977Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/resolve/resolve-primitive-fallback/resolve-primitive-fallback.stderr
2019-12-26T23:21:40.7630529Z To update references, rerun the tests and pass the `--bless` flag
2019-12-26T23:21:40.7631078Z To only update this specific test, also pass `--test-args resolve/resolve-primitive-fallback.rs`
2019-12-26T23:21:40.7631597Z error: 1 errors occurred comparing output.
2019-12-26T23:21:40.7631931Z status: exit code: 1
2019-12-26T23:21:40.7631931Z status: exit code: 1
2019-12-26T23:21:40.7632772Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/resolve/resolve-primitive-fallback.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/resolve/resolve-primitive-fallback" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/resolve/resolve-primitive-fallback/auxiliary" "-A" "unused"
2019-12-26T23:21:40.7633373Z ------------------------------------------
2019-12-26T23:21:40.7633564Z 
2019-12-26T23:21:40.7634305Z ------------------------------------------
2019-12-26T23:21:40.7634551Z stderr:
---
2019-12-26T23:21:40.7642823Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:385:22
2019-12-26T23:21:40.7642894Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-12-26T23:21:40.7653894Z 
2019-12-26T23:21:40.7654161Z 
2019-12-26T23:21:40.7655938Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "7.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-12-26T23:21:40.7658861Z 
2019-12-26T23:21:40.7659865Z 
2019-12-26T23:21:40.7664996Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-12-26T23:21:40.7665058Z Build completed unsuccessfully in 1:03:16
2019-12-26T23:21:40.7665058Z Build completed unsuccessfully in 1:03:16
2019-12-26T23:21:40.7711864Z == clock drift check ==
2019-12-26T23:21:40.7734810Z   local time: Thu Dec 26 23:21:40 UTC 2019
2019-12-26T23:21:41.0730580Z   network time: Thu, 26 Dec 2019 23:21:41 GMT
2019-12-26T23:21:41.0730750Z == end clock drift check ==
2019-12-26T23:21:42.2398050Z 
2019-12-26T23:21:42.2491413Z ##[error]Bash exited with code '1'.
2019-12-26T23:21:42.2585035Z ##[section]Starting: Checkout
2019-12-26T23:21:42.2586633Z ==============================================================================
2019-12-26T23:21:42.2586681Z Task         : Get sources
2019-12-26T23:21:42.2586910Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@sgrif

This comment has been minimized.

Copy link
Contributor

sgrif commented Dec 27, 2019

@Mark-Simulacrum Mark-Simulacrum force-pushed the Mark-Simulacrum:primitive-mod branch from f5499a9 to a58ba90 Dec 27, 2019
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Dec 27, 2019

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-12-27T00:34:12.3367432Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-27T00:34:12.3560454Z ##[command]git config gc.auto 0
2019-12-27T00:34:12.3644449Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-27T00:34:12.3707478Z ##[command]git config --get-all http.proxy
2019-12-27T00:34:12.3845487Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67637/merge:refs/remotes/pull/67637/merge
---
2019-12-27T01:30:37.2559740Z .................................................................................................... 1600/9456
2019-12-27T01:30:41.7602305Z .................................................................................................... 1700/9456
2019-12-27T01:30:50.4977177Z .............................................................................................i...... 1800/9456
2019-12-27T01:30:57.9699784Z .................................................................................................... 1900/9456
2019-12-27T01:31:04.1790614Z ...............................................................................iiiii................ 2000/9456
2019-12-27T01:31:24.3914716Z .................................................................................................... 2200/9456
2019-12-27T01:31:26.5504462Z .................................................................................................... 2300/9456
2019-12-27T01:31:28.8886484Z .................................................................................................... 2400/9456
2019-12-27T01:31:34.9110366Z .................................................................................................... 2500/9456
---
2019-12-27T01:34:20.7743990Z ..........i...............i......................................................................... 4900/9456
2019-12-27T01:34:30.2420060Z .................................................................................................... 5000/9456
2019-12-27T01:34:34.9121322Z ......................................................i............................................. 5100/9456
2019-12-27T01:34:43.6803108Z .................................................................................................... 5200/9456
2019-12-27T01:34:49.5139436Z .....................ii.ii...........i.............................................................. 5300/9456
2019-12-27T01:34:57.8544781Z .................................................................................................... 5500/9456
2019-12-27T01:35:07.9031138Z .................................................................................................... 5600/9456
2019-12-27T01:35:14.6356080Z ...i................................................................................................ 5700/9456
2019-12-27T01:35:19.9579152Z .................................................................................................... 5800/9456
2019-12-27T01:35:19.9579152Z .................................................................................................... 5800/9456
2019-12-27T01:35:29.2988865Z ...........................................................................................ii...i..i 5900/9456
2019-12-27T01:35:41.1113288Z i...........i....................................................................................... 6000/9456
2019-12-27T01:35:57.1879082Z .................................................................................................... 6200/9456
2019-12-27T01:36:04.0409070Z .................................................................................................... 6300/9456
2019-12-27T01:36:04.0409070Z .................................................................................................... 6300/9456
2019-12-27T01:36:19.8196836Z ..................i..ii............................................................................. 6400/9456
2019-12-27T01:36:38.2215199Z ...............................................................................................i.... 6600/9456
2019-12-27T01:36:40.4205026Z .................................................................................................... 6700/9456
2019-12-27T01:36:42.5176806Z ...............................................................................................i.... 6800/9456
2019-12-27T01:36:44.9113397Z .................................................................................................... 6900/9456
---
2019-12-27T01:38:15.4262301Z .................................................................................................... 7500/9456
2019-12-27T01:38:19.8216364Z .................................................................................................... 7600/9456
2019-12-27T01:38:26.0883460Z .................................................................................................... 7700/9456
2019-12-27T01:38:35.9913695Z .................................................................................................... 7800/9456
2019-12-27T01:38:42.1738841Z ..........................iiii...................................................................... 7900/9456
2019-12-27T01:38:55.6309627Z .................................................................................................... 8100/9456
2019-12-27T01:39:04.5826337Z .................................................................................................... 8200/9456
2019-12-27T01:39:17.5340308Z .................................................................................................... 8300/9456
2019-12-27T01:39:24.9128204Z .................................................................................................... 8400/9456
---
2019-12-27T01:41:37.3337664Z  finished in 6.234
2019-12-27T01:41:37.3521601Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-12-27T01:41:37.5404882Z 
2019-12-27T01:41:37.5405969Z running 166 tests
2019-12-27T01:41:40.4136104Z iiii......i........ii..iiii...i.............................i..i..................i....i............ 100/166
2019-12-27T01:41:42.4928144Z i.i.i...iii..iiiiiii.......................iii............ii......
2019-12-27T01:41:42.4929802Z 
2019-12-27T01:41:42.4935274Z  finished in 5.141
2019-12-27T01:41:42.5127930Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-12-27T01:41:42.6754506Z 
---
2019-12-27T01:41:44.5107697Z  finished in 1.998
2019-12-27T01:41:44.5304939Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-12-27T01:41:44.6902607Z 
2019-12-27T01:41:44.6902787Z running 9 tests
2019-12-27T01:41:44.6903578Z iiiiiiiii
2019-12-27T01:41:44.6903942Z 
2019-12-27T01:41:44.6907120Z  finished in 0.160
2019-12-27T01:41:44.7083002Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-12-27T01:41:44.8805908Z 
---
2019-12-27T01:42:03.2252889Z  finished in 18.517
2019-12-27T01:42:03.2483006Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-12-27T01:42:03.4259308Z 
2019-12-27T01:42:03.4259714Z running 124 tests
2019-12-27T01:42:26.7248746Z .iiiii..ii.....i..i...i..i.i.i..i..i..iii....ii.ii....ii..........iiii..........i.....i..ii.......ii 100/124
2019-12-27T01:42:30.7110730Z .i.iii.....iiiiii.....ii
2019-12-27T01:42:30.7111204Z 
2019-12-27T01:42:30.7113413Z  finished in 27.464
2019-12-27T01:42:30.7119723Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-12-27T01:42:30.7120273Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-12-27T01:49:13.1175275Z 
2019-12-27T01:49:13.1175450Z ------------------------------------------
2019-12-27T01:49:13.1175485Z stderr:
2019-12-27T01:49:13.1175642Z ------------------------------------------
2019-12-27T01:49:13.1175702Z error: internal compiler error: src/librustc/hir/def.rs:372: attempted .def_id() on invalid res: PrimTy(Bool)
2019-12-27T01:49:13.1175922Z thread 'rustc' panicked at 'Box<Any>', src/librustc_errors/lib.rs:891:9
2019-12-27T01:49:13.1176471Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-12-27T01:49:13.1176549Z error: aborting due to previous error
2019-12-27T01:49:13.1176581Z 
---
2019-12-27T01:49:13.1177910Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:385:22
2019-12-27T01:49:13.1177970Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-12-27T01:49:13.1184003Z 
2019-12-27T01:49:13.1184101Z 
2019-12-27T01:49:13.1186297Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--rustdoc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc" "--src-base" "/checkout/src/test/rustdoc" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "rustdoc" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "7.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-12-27T01:49:13.1188858Z 
2019-12-27T01:49:13.1188891Z 
2019-12-27T01:49:13.1194017Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-12-27T01:49:13.1194074Z Build completed unsuccessfully in 1:07:52
2019-12-27T01:49:13.1194074Z Build completed unsuccessfully in 1:07:52
2019-12-27T01:49:13.1241359Z == clock drift check ==
2019-12-27T01:49:13.1260529Z   local time: Fri Dec 27 01:49:13 UTC 2019
2019-12-27T01:49:13.4390611Z   network time: Fri, 27 Dec 2019 01:49:13 GMT
2019-12-27T01:49:13.4395101Z == end clock drift check ==
2019-12-27T01:49:16.8838038Z 
2019-12-27T01:49:16.8941625Z ##[error]Bash exited with code '1'.
2019-12-27T01:49:16.8994263Z ##[section]Starting: Checkout
2019-12-27T01:49:16.8995884Z ==============================================================================
2019-12-27T01:49:16.8995928Z Task         : Get sources
2019-12-27T01:49:16.8995983Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member Author

Mark-Simulacrum commented Dec 27, 2019

Failing test looks to be due to a test that makes sure that pub use std::* (which inlines the std crate into the parent crate) works. This unfortunately fails due to the aforementioned rustdoc bug... I guess I'll try and investigate whether it is fixable (#67646).

@Mark-Simulacrum

This comment has been minimized.

Copy link
Member Author

Mark-Simulacrum commented Feb 5, 2020

This has (hopefully) now been unblocked, so I'll be taking another look soon.

@Mark-Simulacrum Mark-Simulacrum force-pushed the Mark-Simulacrum:primitive-mod branch from a58ba90 to b419835 Feb 6, 2020
@Mark-Simulacrum

This comment has been minimized.

Copy link
Member Author

Mark-Simulacrum commented Feb 6, 2020

libcore and libstd are both now a wall of "pub use". libstd has links to the primitive documentation, libcore doesn't (as the docs are defined in libstd, though I'm not sure why).

As noted previously, we don't really have a good stability story here for the common usage pattern (specifically using them directly vs. via an import), at least as far as I can tell:

Hm, actually, now that these are re-exports, direct use is not going to trigger stability lints (e.g., the UI test added by this PR passes without a feature gate). Only use std::primitive; will; not even use std::primitive::bool would. Given that, I think feature gating this doesn't make too much sense, since we're not really gating any functionality, so I've dropped the feature gating in this PR.

So we probably want to invoke FCP merge here. @dtolnay, could you do that?

image

#![feature(arbitrary_self_types)]
#![feature(array_error_internals)]
#![feature(asm)]
#![feature(assoc_int_consts)]
#![feature(associated_type_bounds)]
#![feature(atomic_mut_ptr)]

This comment has been minimized.

Copy link
@Mark-Simulacrum

Mark-Simulacrum Feb 6, 2020

Author Member

This is unrelated (probably autorebase failure). I think the new location is technically the correct one from an alphabetic perspective though (and these seem to be alphabetized...).

@rust-highfive

This comment was marked as resolved.

Copy link
Collaborator

rust-highfive commented Feb 6, 2020

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2020-02-06T14:27:12.0428777Z ========================== Starting Command Output ===========================
2020-02-06T14:27:12.0549840Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/b120899a-fbc6-4383-a7d2-191cf6705649.sh
2020-02-06T14:27:12.0650629Z 
2020-02-06T14:27:12.0700038Z ##[section]Finishing: Disable git automatic line ending conversion
2020-02-06T14:27:12.0704452Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/67637/merge to s
2020-02-06T14:27:12.0705938Z Task         : Get sources
2020-02-06T14:27:12.0705966Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-02-06T14:27:12.0705992Z Version      : 1.0.0
2020-02-06T14:27:12.0706045Z Author       : Microsoft
---
2020-02-06T14:27:12.8303232Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-02-06T14:27:12.8387423Z ##[command]git config gc.auto 0
2020-02-06T14:27:12.8460223Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-02-06T14:27:12.8514204Z ##[command]git config --get-all http.proxy
2020-02-06T14:27:12.8665654Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67637/merge:refs/remotes/pull/67637/merge
---
2020-02-06T15:19:44.2804045Z .................................................................................................... 1700/9590
2020-02-06T15:19:48.6755338Z .................................................................................................... 1800/9590
2020-02-06T15:19:59.9753386Z .............................i...................................................................... 1900/9590
2020-02-06T15:20:06.5591300Z .................................................................................................... 2000/9590
2020-02-06T15:20:19.6443285Z ...................iiiii............................................................................ 2100/9590
2020-02-06T15:20:28.6876065Z .................................................................................................... 2300/9590
2020-02-06T15:20:31.0106170Z .................................................................................................... 2400/9590
2020-02-06T15:20:35.7009042Z .................................................................................................... 2500/9590
2020-02-06T15:20:54.7043466Z .................................................................................................... 2600/9590
---
2020-02-06T15:23:16.1656602Z ..............................................................i...............i..................... 4900/9590
2020-02-06T15:23:22.8116867Z .................................................................................................... 5000/9590
2020-02-06T15:23:29.9566890Z .................................................................................................... 5100/9590
2020-02-06T15:23:34.1079385Z .....i.............................................................................................. 5200/9590
2020-02-06T15:23:43.9764073Z ...............................................................................ii.ii........i...i... 5300/9590
2020-02-06T15:23:51.6636693Z .................i.................................................................................. 5500/9590
2020-02-06T15:23:59.9977092Z .................................................................................................... 5600/9590
2020-02-06T15:24:06.1307692Z ..................................................................i................................. 5700/9590
2020-02-06T15:24:12.5411362Z .................................................................................................... 5800/9590
2020-02-06T15:24:12.5411362Z .................................................................................................... 5800/9590
2020-02-06T15:24:18.9471051Z .................................................................................................... 5900/9590
2020-02-06T15:24:27.3384010Z .........................................................ii...i..ii...........i..................... 6000/9590
2020-02-06T15:24:46.9229609Z .................................................................................................... 6200/9590
2020-02-06T15:24:53.7216952Z .................................................................................................... 6300/9590
2020-02-06T15:24:53.7216952Z .................................................................................................... 6300/9590
2020-02-06T15:25:00.9599947Z .....................................................................................i..ii.......... 6400/9590
2020-02-06T15:25:22.4844196Z .................................................................................................... 6600/9590
2020-02-06T15:25:30.9024877Z .......................................................................i............................ 6700/9590
2020-02-06T15:25:32.9891532Z .................................................................................................... 6800/9590
2020-02-06T15:25:35.1254213Z .........................................................................i.......................... 6900/9590
---
2020-02-06T15:27:03.4150210Z .................................................................................................... 7600/9590
2020-02-06T15:27:07.5785073Z .................................................................................................... 7700/9590
2020-02-06T15:27:13.6766634Z .................................................................................................... 7800/9590
2020-02-06T15:27:21.3251971Z .................................................................................................... 7900/9590
2020-02-06T15:27:28.0302611Z ....................................iiiiiii.i....................................................... 8000/9590
2020-02-06T15:27:41.3031434Z .................................................................................................... 8200/9590
2020-02-06T15:27:48.5389250Z .................................................................................................... 8300/9590
2020-02-06T15:28:01.0706499Z .................................................................................................... 8400/9590
2020-02-06T15:28:07.5664342Z .................................................................................................... 8500/9590
---
2020-02-06T15:30:16.6971136Z  finished in 6.988
2020-02-06T15:30:16.7128881Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-02-06T15:30:16.8584475Z 
2020-02-06T15:30:16.8585989Z running 172 tests
2020-02-06T15:30:19.6462556Z iiii......i...........ii..iiii...i....i...........i............i..i..................i....i......... 100/172
2020-02-06T15:30:21.7235988Z ...i.i.i...iii..iiiiiiiiii.......................iii............ii......
2020-02-06T15:30:21.7240274Z 
2020-02-06T15:30:21.7245071Z  finished in 5.011
2020-02-06T15:30:21.7440704Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-02-06T15:30:21.8758986Z 
---
2020-02-06T15:30:23.7315586Z  finished in 1.987
2020-02-06T15:30:23.7523255Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-02-06T15:30:23.8894690Z 
2020-02-06T15:30:23.8895227Z running 9 tests
2020-02-06T15:30:23.8896145Z iiiiiiiii
2020-02-06T15:30:23.8896709Z 
2020-02-06T15:30:23.8904461Z  finished in 0.138
2020-02-06T15:30:23.9049572Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-02-06T15:30:24.0483128Z 
---
2020-02-06T15:30:42.6820060Z  finished in 18.777
2020-02-06T15:30:42.6985041Z Check compiletest suite=debuginfo mode=debuginfo (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-02-06T15:30:42.8365120Z 
2020-02-06T15:30:42.8365881Z running 116 tests
2020-02-06T15:30:55.0984229Z iiiii..i.....i..i...i..i.i.i..i..i..ii....i.i....ii..........iiii..........i.....i..i.......ii.i.ii. 100/116
2020-02-06T15:30:56.7657017Z ....iiii.....ii.
2020-02-06T15:30:56.7657940Z 
2020-02-06T15:30:56.7699419Z  finished in 14.067
2020-02-06T15:30:56.7699824Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2020-02-06T15:30:56.7700107Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2020-02-06T15:43:02.0239636Z 
2020-02-06T15:43:02.0240323Z    Doc-tests core
2020-02-06T15:43:06.4189270Z 
2020-02-06T15:43:06.4190259Z running 2473 tests
2020-02-06T15:43:14.7658036Z ......iiiii......................................................................................... 100/2473
2020-02-06T15:43:22.6767651Z ..................................................................................ii................ 200/2473
2020-02-06T15:43:41.1906787Z .................i.................................................................................. 400/2473
2020-02-06T15:43:41.1906787Z .................i.................................................................................. 400/2473
2020-02-06T15:43:49.8436859Z ......................................................................i..i..................iiii.... 500/2473
2020-02-06T15:44:04.6783244Z .................................................................................................... 700/2473
2020-02-06T15:44:12.1514522Z .................................................................................................... 800/2473
2020-02-06T15:44:20.5504209Z .................................................................................................... 900/2473
2020-02-06T15:44:29.2717259Z .................................................................................................... 1000/2473
---
2020-02-06T15:46:34.5211528Z   local time: Thu Feb  6 15:46:34 UTC 2020
2020-02-06T15:46:34.8123546Z   network time: Thu, 06 Feb 2020 15:46:34 GMT
2020-02-06T15:46:34.8127071Z == end clock drift check ==
2020-02-06T15:46:35.1627796Z 
2020-02-06T15:46:35.1764679Z ##[error]Bash exited with code '1'.
2020-02-06T15:46:35.1775452Z ##[section]Finishing: Run build
2020-02-06T15:46:35.1793567Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/67637/merge to s
2020-02-06T15:46:35.1795310Z Task         : Get sources
2020-02-06T15:46:35.1795352Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-02-06T15:46:35.1795406Z Version      : 1.0.0
2020-02-06T15:46:35.1795439Z Author       : Microsoft
2020-02-06T15:46:35.1795439Z Author       : Microsoft
2020-02-06T15:46:35.1795476Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-02-06T15:46:35.1795531Z ==============================================================================
2020-02-06T15:46:35.5492738Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-02-06T15:46:35.5529839Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/67637/merge to s
2020-02-06T15:46:35.5637509Z Cleaning up task key
2020-02-06T15:46:35.5638351Z Start cleaning up orphan processes.
2020-02-06T15:46:35.5733096Z Terminate orphan process: pid (3693) (python)
2020-02-06T15:46:35.5979464Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Mark-Simulacrum Mark-Simulacrum force-pushed the Mark-Simulacrum:primitive-mod branch from b419835 to b26cd43 Feb 6, 2020
src/libcore/primitive.rs Outdated Show resolved Hide resolved
This re-exports the primitive types from libcore at `core::primitive` to allow
macro authors to have a reliable location to use them from.
@Mark-Simulacrum Mark-Simulacrum force-pushed the Mark-Simulacrum:primitive-mod branch from b26cd43 to 178de46 Feb 6, 2020
@dtolnay dtolnay added this to the 1.43 milestone Feb 8, 2020
@dtolnay

This comment has been minimized.

Copy link
Member

dtolnay commented Feb 8, 2020

@rfcbot fcp merge

This PR adds stable re-exports of the primitive types under core::primitive and std::primitive, e.g. core::primitive::i32. The new module includes bool, char, str, iN, uN, fN. These are types that have so far not had a way to import by absolute path from the standard library, which has been problematic in macro DSLs where these names might refer to something other than the primitive types.

@rfcbot

This comment has been minimized.

Copy link

rfcbot commented Feb 8, 2020

Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot

This comment has been minimized.

Copy link

rfcbot commented Feb 12, 2020

🔔 This is now entering its final comment period, as per the review above. 🔔

//! ```

#[stable(feature = "core_primitive", since = "1.42.0")]
pub use bool;

This comment has been minimized.

Copy link
@jplatte

jplatte Feb 13, 2020

Contributor

Could these re-exports not be merged, so the attribute doesn't have to be repeated a bunch of times?

pub use {
    bool,
    char,
    ...
};

This comment has been minimized.

Copy link
@Mark-Simulacrum

Mark-Simulacrum Feb 13, 2020

Author Member

I consider multiline use a mistake in most cases as it breaks grepping for use.*Identifier, so I'm not going to change this, but I believe it is possible.

@rfcbot

This comment has been minimized.

Copy link

rfcbot commented Feb 22, 2020

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

7 participants
You can’t perform that action at this time.