Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make `u8::is_ascii` a stable `const fn` #68984

Merged
merged 2 commits into from Feb 22, 2020

Conversation

@ecstatic-morse
Copy link
Contributor

ecstatic-morse commented Feb 9, 2020

char::is_ascii was already stabilized as const fn in #55278, so there is no reason for u8::is_ascii to go through an unstable period.

cc @rust-lang/libs

`char::is_ascii` is already a stable `const fn`, so there is no reason
for `u8::is_ascii` to be unstable.
@jonas-schievink jonas-schievink added this to the 1.43 milestone Feb 9, 2020
@jonas-schievink

This comment has been minimized.

Copy link
Member

jonas-schievink commented Feb 9, 2020

@LukasKalbertodt

This comment has been minimized.

Copy link
Member

LukasKalbertodt commented Feb 9, 2020

👍 on the code changes and the stabilization. But as I can't start FCP merges, reassigning:

r? @sfackler

@sfackler

This comment has been minimized.

Copy link
Member

sfackler commented Feb 9, 2020

@rfcbot fcp merge

@rfcbot

This comment has been minimized.

Copy link

rfcbot commented Feb 9, 2020

Team member @sfackler has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot

This comment has been minimized.

Copy link

rfcbot commented Feb 13, 2020

🔔 This is now entering its final comment period, as per the review above. 🔔

@sfackler

This comment has been minimized.

Copy link
Member

sfackler commented Feb 21, 2020

@bors r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 21, 2020

📌 Commit bf732a1 has been approved by sfackler

bors added a commit that referenced this pull request Feb 22, 2020
Rollup of 7 pull requests

Successful merges:

 - #68984 (Make `u8::is_ascii` a stable `const fn`)
 - #69339 (Add test for #69312)
 - #69346 (Clean up E0323, E0324, E0325 and E0326 explanations)
 - #69348 (Wrong error message for move_ref_pattern)
 - #69349 (MIR is not an experiment anymore)
 - #69354 (Test `Duration::new` panics on overflow)
 - #69370 (move const_eval.rs into the module folder)

Failed merges:

r? @ghost
@bors bors merged commit c261ff1 into rust-lang:master Feb 22, 2020
4 checks passed
4 checks passed
pr Build #20200209.16 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-7) Linux x86_64-gnu-llvm-7 succeeded
Details
pr (Linux x86_64-gnu-tools) Linux x86_64-gnu-tools succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.