Conversation
senekor
approved these changes
Aug 4, 2026
senekor
left a comment
Contributor
There was a problem hiding this comment.
The timeout for exercises seems reasonable... but practically, how useful are 30 seconds? I expect most people to hit Ctrl+C before that. Making the timeout too tight seems risky, I don't know how long we should expect compilation to take on weak / old hardware... especially considering we want to add exercises with dependencies like tokio.
Contributor
Author
|
We might need to add either a global configuration option or even allow one for every exercise, especially for community exercises. But I would wait for someone to complain :P |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2394
Reworked the visualization of the check-all progress. Instead of showing the exercise numbers, an exercise is shown with "done" or "pending" after being checked. To see the output, run
cargo r -- check-all.I also removed the manual input
cto trigger check-all. It was offered as an option to avoid hittingnmultiple times when the state file is out of sync (e.g. user continues on a different machine without syncing the state file). Instead of a manual trigger, check-all is now triggered automatically when the user hitsnand the next exercise is done although it was not marked as such. This means that at least one exercise is done and not marked as such and check-all will fix possible others.Rather orthogonal, but I did it on the way: I added a timeout to all commands in case a user writes a program which does not terminate. Currently, it is set to 30sec. What do you think about that value? @senekor