Conversation
Brave can't be told apart from Chrome through the user agent string, so detection uses `navigator.brave` with `navigator.userAgentData.brands` as fallback. Both are synchronous, unlike `navigator.brave.isBrave()` -- the flavor must be settled before filter lists are compiled and cached. Brave still offers uBO in MV2, and a considerable number of Brave users run Brave Shields and uBO at the same time. Filters which are safe on their own can conflict when both blockers apply them, and list maintainers currently have no way to express that: uBlockOrigin/uAssets#34162
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an
env_bravepreparser token so filter lists can target Brave.Brave can't be told apart from Chrome through the user agent string, so detection uses
navigator.bravewithnavigator.userAgentData.brandsas fallback. Both are synchronous, unlikenavigator.brave.isBrave()— the flavor has to be settled before lists are compiled and cached.chromiumstays in the soup alongsidebrave.Brave still offers uBO in MV2, and a considerable number of Brave users run Brave Shields and uBO at the same time. Filters that are safe on their own can conflict when both blockers apply them, and list maintainers currently have no way to express that: uBlockOrigin/uAssets#34162 (YouTube infinite reload loop from duelling mutation observers; an exception rule scoped to Brave measured a 30% reduction in YouTube issue reports, and removing it put them back).
MV2 only. The parser change reaches uBOL via
make-mv3.shbut resolves false there, since MV3 prunes at build time.Disclosure: I work at Brave.