Reimplement release creation workflow #39083
Conversation
|
Documentation preview for this PR (built with commit 4aea0e0; changes) is ready! 🎉 |
|
@soham30rane Would you review? |
| https://api.github.com/repos/${{ github.repository }}/releases \ | ||
| -d '{ | ||
| "tag_name": "${{ github.ref_name }}", | ||
| "previous_tag_name": "${latest_release_tag}", | ||
| "prerelease": ${{ contains(github.ref, 'beta') || contains(github.ref, 'rc') }}, | ||
| "generate_release_notes": true | ||
| }' |
There was a problem hiding this comment.
I went through the official docs and didn't found parameter previous_tag_name for Create a release endpoint. So it seems, even if generate_release_notes is set to true, the previous_tag_name plays no role.
The parameter previous_tag_name exists for generate release notes endpoint. This endpoint will return the name and body according to specified parameters, which could be then used to create a release using create a release endpoint
There was a problem hiding this comment.
Nonetheless it works fine.
It seems that "generate_release_notes": true internally triggers the "generate release notes" endpoint as well, which uses previous_tag_name.
There was a problem hiding this comment.
I will check again.
|
Sorry for the confusing state of this PR. By an accident related with my privileged account (damn it!), I erroneously merged this PR branch to the develop branch. I instantly restored the develop branch, but I cannot restore this PR to the previous state. So I created a new PR #39194 for the branch. Sorry for inconveniences. |
2 participants
Fixes the issue raised in sagemath/website#480 (comment)
I manually edited the release https://github.com/sagemath/sage/releases/tag/10.5 generated by an workflow implemented in sagemath/website#480 to correct the changelog https://github.com/sagemath/website/blob/master/src/changelogs/sage-10.5.txt, which is now in good shape. But see, for example, https://github.com/sagemath/sage/releases/tag/10.4 that contains all changes in betas and rcs.
This PR is for automatic generation of a release that contains only changes from the last release.
test:
https://github.com/kwankyu/sage/releases
https://github.com/kwankyu/sage/actions/runs/12191414258/job/34010494299
📝 Checklist
⌛ Dependencies