Skip to content

Fix test failure from #40435 #40694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2025
Merged

Fix test failure from #40435 #40694

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/sage/matrix/matrix_gfpn_dense.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,6 +689,7 @@ cdef class Matrix_gfpn_dense(Matrix_dense):

TESTS::

sage: from sage.matrix.matrix_gfpn_dense import Matrix_gfpn_dense
sage: K.<z> = GF(59)
sage: M = MatrixSpace(K, 3, 4, implementation=Matrix_gfpn_dense)(range(12))
Comment on lines +692 to 694
Copy link
Contributor

@xcaruso xcaruso Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sage: from sage.matrix.matrix_gfpn_dense import Matrix_gfpn_dense
sage: K.<z> = GF(59)
sage: M = MatrixSpace(K, 3, 4, implementation=Matrix_gfpn_dense)(range(12))
sage: K.<z> = GF(25)
sage: M = MatrixSpace(K, 3, 4, implementation='meataxe')(range(12)) # optional - meataxe, needs sage.rings.finite_rings

Copy link
Contributor Author

@antonio-rojas antonio-rojas Aug 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work for me, it gives a AssertionError. Also, the optional - meataxe directive is not necessary as it's already present at the top of the file

sage: M
Expand Down
Loading