add parameter immutable to distance regular graph generators (part 1) #40740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit f75b10c; changes) is ready! 🎉 |
Contributor
|
LGTM. I think it is better to add a doctest to generate a immutable graph successfully |
cxzhong
approved these changes
Nov 19, 2025
Contributor
Author
|
Thank you for the review. Should I add a doctest per method ? My main concern is that doctesting this module is already long, so adding doctests to show that we can generate immutable graphs might make it even longer. |
Contributor
Just add one, to show that we can generate a graph which is immutable indeed. and for copy method. we need to show the immutable graph generated by copy method is also immutable. |
Contributor
Author
|
Let me know if this is what you expected. |
cxzhong
approved these changes
Nov 19, 2025
Contributor
|
Thank you very much |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 20, 2025
sagemathgh-40740: add parameter immutable to distance regular graph generators (part 1) Following discussions in sagemath#39177, we add the option to return immutable graphs to some generators in `src/sage/graphs/generators/ditance_regular.pyx`. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40740 Reported by: David Coudert Reviewer(s): Chenxin Zhong
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 21, 2025
sagemathgh-40740: add parameter immutable to distance regular graph generators (part 1) Following discussions in sagemath#39177, we add the option to return immutable graphs to some generators in `src/sage/graphs/generators/ditance_regular.pyx`. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40740 Reported by: David Coudert Reviewer(s): Chenxin Zhong
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 26, 2025
sagemathgh-40740: add parameter immutable to distance regular graph generators (part 1) Following discussions in sagemath#39177, we add the option to return immutable graphs to some generators in `src/sage/graphs/generators/ditance_regular.pyx`. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40740 Reported by: David Coudert Reviewer(s): Chenxin Zhong
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 1, 2025
sagemathgh-40740: add parameter immutable to distance regular graph generators (part 1) Following discussions in sagemath#39177, we add the option to return immutable graphs to some generators in `src/sage/graphs/generators/ditance_regular.pyx`. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40740 Reported by: David Coudert Reviewer(s): Chenxin Zhong
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussions in #39177, we add the option to return immutable graphs to some generators in
src/sage/graphs/generators/ditance_regular.pyx.📝 Checklist
⌛ Dependencies