Remove unused variables (mostly SAGE_VENV) #41358
Open
+33
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit e0262fb; changes) is ready! 🎉 |
|
|
||
| # prefix hierarchy where non-Python packages are installed | ||
| SAGE_LOCAL = var("SAGE_LOCAL", SAGE_VENV) | ||
| SAGE_LOCAL = var("SAGE_LOCAL") |
Contributor
There was a problem hiding this comment.
any reason to drop the sys.prefix fallback?
Contributor
Author
There was a problem hiding this comment.
SAGE_LOCAL is set unconditionally in config.py.in (which gets used in var) to the prefix that was specified to meson. So there is no need for a fallback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a few (mostly) unused variables, that are anyway not set anymore via meson.
Triggered by https://groups.google.com/g/sage-devel/c/etw_X5HlXMY
📝 Checklist
⌛ Dependencies