書き込み範囲のチェック漏れ対策(CUtf7) - #1869
Merged
berryzplus merged 1 commit intoDec 14, 2022
Merged
Conversation
berryzplus
marked this pull request as draft
November 6, 2022 09:53
berryzplus
force-pushed
the
feature/fix_bufferoverflow_cutf7
branch
from
November 6, 2022 09:57
b922e70 to
ce00e77
Compare
|
✅ Build sakura 1.0.4191 completed (commit 7badae8dea by @berryzplus) |
|
Kudos, SonarCloud Quality Gate passed! |
|
✅ Build sakura 1.0.4192 completed (commit 7abacd13c2 by @berryzplus) |
berryzplus
marked this pull request as ready for review
November 6, 2022 10:44
kasumikagari
approved these changes
Nov 27, 2022
kasumikagari
left a comment
kasumikagari
left a comment
Member
There was a problem hiding this comment.
お久しぶりです。都合により @k-kagari から ID を変更しました。
読み取り範囲のオーバーフロー、誤検知と考えられる
書き込み範囲のオーバーフロー、実害はないが関数仕様として対策必須
品質向上という目標に対していずれも適切な対処だと思います。承認しておきます。
Contributor
Author
|
レビューありがとうございます。マージします。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR の目的
SonarCloudで検出されているBlockerレベルのBugs指摘を潰して、コードに対する安心感を向上させます。
カテゴリ
PR の背景
SonarCloudでBlockerレベルのBugs警告が2件発生しています。
https://sonarcloud.io/project/issues?resolved=false&severities=BLOCKER&types=BUG&id=sakura-editor_sakura
PR のメリット
PR のデメリット (トレードオフとかあれば)
仕様・動作説明
対応する指摘は以下2つです。
内容の説明は不要と思うので必要でしたら言ってください。
PR の影響範囲
文字セットUTF7の読み込み、書き込み、変換に影響する変更です。
（実態として機能変更はありません。）
テスト内容
関連 issue, PR
参考資料