Skip to content

fix: repair release preflight - #207

Merged
salasebas merged 2 commits into
mainfrom
agent/fix-release-preflight-206
Jul 20, 2026
Merged

fix: repair release preflight#207
salasebas merged 2 commits into
mainfrom
agent/fix-release-preflight-206

Conversation

@salasebas

@salasebas salasebas commented Jul 17, 2026

Copy link
Copy Markdown
Owner

Summary

  • break the same-release rustauth / rustauth-fred package-verification cycle by moving Fred cross-crate/live tests into an unpublished integration-test crate
  • correct the documented publication graph and order, including the rustauth-passkeyrustauth-plugins verification edge
  • add a required CI preflight that rejects publication cycles, missing packages, and dependency-order drift

Rebase note

Rebased onto main at 58319769 (#208). Main already contains the Rust 1.97 Clippy rewrite and duplicate workflow_dispatch removal originally included here, so those changes are no longer part of this PR's diff. The Integration workflow keeps #208's serialized rustauth-cli tests and this PR only replaces the Fred live-test matrix entry with rustauth-integration-tests.

Root cause

Versioned dev-dependencies in rustauth-fred are retained by Cargo during package verification. Fred therefore required the same-release rustauth facade, while the facade normally/optionally required Fred, leaving no valid clean publication order.

The documented order also placed rustauth-plugins before its versioned verification dependency rustauth-passkey.

Validation

  • cargo fmt --all --check
  • cargo deny check — advisories, bans, licenses, and sources pass
  • env RUSTC_WRAPPER= cargo +1.97.0 clippy --workspace --all-targets --all-features -- -D warnings
  • env RUSTC_WRAPPER= cargo nextest run -p rustauth-fred --all-features — 19 passed
  • env RUSTC_WRAPPER= cargo nextest run -p rustauth-integration-tests --all-features — 22 passed against local Redis
  • python3 -m unittest discover -s scripts/tests -p test_check_release_order.py — 5 passed
  • python3 scripts/check_release_order.py — 23 publishable packages and 68 packaged workspace edges, acyclic and correctly ordered
  • zizmor --offline --strict-collection --no-exit-codes .github/workflows/ci.yml .github/workflows/integration.yml — both workflows parse; only pre-existing action pin/cache findings remain
  • cargo package -p rustauth-fred --allow-dirty --offline --no-verify — package succeeds and retains only the expected core/time/tokio dev-dependencies

Closes #206

@vercel

vercel Bot commented Jul 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
rustauth-docs-site Ignored Ignored Jul 20, 2026 7:05pm

Comment thread .github/workflows/ci.yml

steps:
- name: Checkout
uses: actions/checkout@v4
Comment thread .github/workflows/ci.yml
Comment on lines +76 to +77
- name: Checkout
uses: actions/checkout@v4
@salasebas
salasebas force-pushed the agent/fix-release-preflight-206 branch from 99cd259 to 0ac183b Compare July 20, 2026 18:50
@salasebas
salasebas marked this pull request as ready for review July 20, 2026 19:15
@salasebas
salasebas merged commit aee52ab into main Jul 20, 2026
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix release preflight: Clippy, Integration workflow, and publication cycle

2 participants