fix(ci): restore failing checks - #208
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
salasebas
marked this pull request as ready for review
July 20, 2026 18:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workflow_dispatchkeycrossbeam-epoch,quick-xml, and the pinnedopensamlrevision to remove the active RustSec findingsopensaml/quick-xmlAPIs while preserving logout correlation behavior and configured encrypted-assertion compatibilityRoot cause
CI had three independent failures:
clippy::question_markbecame a denied warning in the IPv6 host/port parser..github/workflows/integration.ymlcontainedworkflow_dispatchtwice, so GitHub rejected the workflow before creating any jobs.RUSTSEC-2026-0204incrossbeam-epoch 0.9.18andRUSTSEC-2026-0194/RUSTSEC-2026-0195inquick-xml 0.37.5. The vulnerable quick-xml paths are reachable from SAML processing, so the findings are fixed through upgrades rather than ignored.Impact
The primary CI, integration workflow, and scheduled dependency audit can run successfully again. SAML parsing retains its existing behavior on the upgraded XML stack, including entity decoding, signature checks, logout responses, and encrypted assertions configured with a PEM decryption key.
Validation
cargo fmt --all --checkcargo +1.97.0 clippy --workspace --all-targets --all-features -- -D warningscargo deny checkcargo nextest run -p rustauth-core --all-features— 630 passedcargo nextest run -p rustauth-saml --all-features— 36 passedcargo nextest run -p rustauth-sso --all-features— 348 passedgit diff --checkcargo denystill reports the pre-existing non-blockingspin 0.9.8yanked warning and unmatched license allowances; advisories, bans, licenses, and sources all pass.