Add efficiency operating hull to three-regime co-design study - #53
Merged
Conversation
…ocs and commit generated artifacts
Copilot
AI
changed the title
[WIP] Add efficiency operating hull to three-regime study
Add efficiency operating hull to three-regime co-design study
Jul 11, 2026
salhus
marked this pull request as ready for review
July 11, 2026 22:18
This was referenced Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the three-regime study with a mask-respecting efficiency operating hull (companion to the existing power hull), embeds both hull tables in
FINDINGS_3REGIME.md, and adds divergence analysis showing the two co-design schedules differ at 17 of 27 period points.Script changes (
scripts/three_regime_comparison.py)_build_efficiency_envelope()— per-period max(η) hull with strict masking: excludesmasked==True,linear_popt_invalid==True, NaN η, and η > 1+ε. All-masked periods emiteta_max=NaN, masked=Truerather than fabricating a value._write_efficiency_envelope_csv()— writesT_s, eta_max, controller, flap_angle, maskedplot_operating_envelope_efficiency()— journal-style figure matching power envelope style; hatches all-masked periodsmain()— both hulls now regenerate in a single--plot-onlyinvocationREGIME_LABEL_Y = 0.95constant (applied to both envelope plots)Documentation (
analysis/FINDINGS_3REGIME.md§4)Restructured §4 into three subsections:
masked=true); efficiency hull correctly excludes these and selects ff+PID + resonance-matched higher-angle flapsdocs/CONTROLLERS.mdAdded efficiency envelope outputs to the three-regime reproduction section with the mask-respecting rule documented.
.gitignoreAdded allowlist exceptions for
analysis/three_regime/*.csvandanalysis/three_regime/figures/*.pngso generated artifacts are committable.Committed artifacts
analysis/three_regime/operating_envelope.csv(power hull)analysis/three_regime/operating_envelope_efficiency.csv(efficiency hull — verified: no η>1 spikes)analysis/three_regime/figures/operating_envelope_efficiency.png