Allow to configure pam service - #205
Merged
Merged
Conversation
This allows distros to customize this for phrog. We use the somewhat long `general_service` as upcoming greetd releases will allow to configure the services for the individual sessions too. Signed-off-by: Guido G眉nther <agx@sigxcpu.org>
Let's provide a Phosh specific PAM config as the distro defaults usually don't unlock the keyring. Signed-off-by: Guido G眉nther <agx@sigxcpu.org>
Owner
|
LGTM, thanks. I'll sort out the (new, unrelated to changes here) CI failures separately. |
Collaborator
Author
|
That was fast, thanks! |
Owner
It's nice to wave through some high quality fleshware-curated diff rather than AI slop for a change :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Debian we relied on greetd using a pam config to unlock session keyrings. This has been dropped so provide a way to configure PAM so it's useful in Phosh.
Related Debian issue: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1143492